Skip to content

Commit ff198c3

Browse files
XynoclafeXynoclafe
committed
Renamed some parameters
1 parent 89258a1 commit ff198c3

11 files changed

+50
-51
lines changed

‎src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzDeploymentStackSnapshot.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,18 @@ public class GetAzDeploymentStackSnapshot : DeploymentStacksCmdletBase
3232
internal const string GetByResourceIdParameterSetName = "GetDeploymentStackByResourceId";
3333
internal const string ListParameterSetname = "ListDeploymentStacks";
3434

35-
[Alias("StackName")]
3635
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = GetByStackNameParameterSetname,
3736
HelpMessage = "The name of the deploymentStack to get")]
3837
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = ListParameterSetname,
3938
HelpMessage = "The name of the deploymentStack to get")]
4039
[ValidateNotNullOrEmpty]
41-
public string Name { get; set; }
40+
public string StackName { get; set; }
4241

42+
[Alias("SnapshotName")]
4343
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = GetByStackNameParameterSetname,
4444
HelpMessage = "The name of the deploymentStack to get")]
4545
[ValidateNotNullOrEmpty]
46-
public string SnapshotName { get; set; }
46+
public string Name { get; set; }
4747

4848
[Alias("Id")]
4949
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = GetByResourceIdParameterSetName,
@@ -62,16 +62,16 @@ public override void ExecuteCmdlet()
6262
switch (ParameterSetName)
6363
{
6464
case GetByStackNameParameterSetname:
65-
WriteObject(DeploymentStacksSdkClient.GetSubscriptionDeploymentStackSnapshot(Name, SnapshotName));
65+
WriteObject(DeploymentStacksSdkClient.GetSubscriptionDeploymentStackSnapshot(StackName, Name));
6666
break;
6767
case GetByResourceIdParameterSetName:
6868
ResourceIdentifier resourceIdentifier = new ResourceIdentifier(ResourceId);
69-
Name = ResourceIdUtility.GetResourceName(ResourceId).Split('/')[0];
70-
SnapshotName = resourceIdentifier.ResourceName;
71-
WriteObject(DeploymentStacksSdkClient.GetSubscriptionDeploymentStackSnapshot(Name, SnapshotName));
69+
StackName = ResourceIdUtility.GetResourceName(ResourceId).Split('/')[0];
70+
Name = resourceIdentifier.ResourceName;
71+
WriteObject(DeploymentStacksSdkClient.GetSubscriptionDeploymentStackSnapshot(StackName, Name));
7272
break;
7373
case ListParameterSetname:
74-
WriteObject(DeploymentStacksSdkClient.ListSubscriptionDeploymentStackSnapshot(Name));
74+
WriteObject(DeploymentStacksSdkClient.ListSubscriptionDeploymentStackSnapshot(StackName));
7575
break;
7676
default:
7777
throw new PSInvalidOperationException();

‎src/Resources/ResourceManager/Implementation/DeploymentStacks/GetAzResourceGroupDeploymentStackSnapshot.cs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@ public class GetAzResourceGroupDeploymentStackSnapshot : DeploymentStacksCmdletB
4040
[ValidateNotNullOrEmpty]
4141
public string ResourceGroupName { get; set; }
4242

43-
[Alias("StackName")]
4443
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = GetByDeploymentStackName)]
4544
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = ListByResourceGroupNameParameterSetName)]
4645
[ValidateNotNullOrEmpty]
47-
public string Name { get; set; }
46+
public string StackName { get; set; }
4847

48+
[Alias("SnapshotName")]
4949
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = GetByDeploymentStackName)]
5050
[ValidateNotNullOrEmpty]
51-
public string SnapshotName { get; set; }
51+
public string Name { get; set; }
5252

5353
#endregion
5454

@@ -61,17 +61,15 @@ public override void ExecuteCmdlet()
6161
{
6262
case GetByResourceIdParameterSetName:
6363
ResourceIdentifier resourceIdentifier = new ResourceIdentifier(ResourceId);
64-
Name = ResourceIdUtility.GetResourceName(ResourceId).Split('/')[0];
65-
WriteObject(ResourceIdUtility.GetResourceName(ResourceId));
66-
WriteObject(Name);
67-
SnapshotName = resourceIdentifier.ResourceName;
68-
WriteObject(DeploymentStacksSdkClient.GetResourceGroupDeploymentStackSnapshot(ResourceIdUtility.GetResourceGroupName(ResourceId), Name, SnapshotName));
64+
StackName = ResourceIdUtility.GetResourceName(ResourceId).Split('/')[0];
65+
Name = resourceIdentifier.ResourceName;
66+
WriteObject(DeploymentStacksSdkClient.GetResourceGroupDeploymentStackSnapshot(ResourceIdUtility.GetResourceGroupName(ResourceId), StackName, Name));
6967
break;
7068
case ListByResourceGroupNameParameterSetName:
71-
WriteObject(DeploymentStacksSdkClient.ListResourceGroupDeploymentStackSnapshot(ResourceGroupName, Name));
69+
WriteObject(DeploymentStacksSdkClient.ListResourceGroupDeploymentStackSnapshot(ResourceGroupName, StackName));
7270
break;
7371
case GetByDeploymentStackName:
74-
WriteObject(DeploymentStacksSdkClient.GetResourceGroupDeploymentStackSnapshot(ResourceGroupName, Name, SnapshotName));
72+
WriteObject(DeploymentStacksSdkClient.GetResourceGroupDeploymentStackSnapshot(ResourceGroupName, StackName, Name));
7573
break;
7674
default:
7775
throw new PSInvalidOperationException();

‎src/Resources/ResourceManager/Implementation/DeploymentStacks/NewAzResourceGroupDeploymentStack.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public class NewAzResourceGroupDeploymentStack : DeploymentStacksCmdletBase
7979
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "ResourceId of the TemplateSpec to be used to create the stack")]
8080
[Parameter(Position = 2, ParameterSetName = ParameterlessTemplateSpecParameterSetName,
8181
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "ResourceId of the TemplateSpec to be used to create the stack")]
82-
public string TemplateSpec { get; set; }
82+
public string TemplateSpecId { get; set; }
8383

8484
[Parameter(Position = 3, ParameterSetName = ParameterFileTemplateFileParameterSetName,
8585
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "Parameter file to use for the template")]
@@ -159,7 +159,7 @@ public override void ExecuteCmdlet()
159159
Name,
160160
ResourceGroupName,
161161
TemplateUri,
162-
TemplateSpec,
162+
TemplateSpecId,
163163
ParameterUri,
164164
parameters,
165165
Description,

‎src/Resources/ResourceManager/Implementation/DeploymentStacks/NewAzSubscriptionDeploymentStack.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public class NewAzSubscriptionDeploymentStack : DeploymentStacksCmdletBase
7373
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "ResourceId of the TemplateSpec to be used to create the stack")]
7474
[Parameter(Position = 1, ParameterSetName = ParameterlessTemplateSpecParameterSetName,
7575
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "ResourceId of the TemplateSpec to be used to create the stack")]
76-
public string TemplateSpec { get; set; }
76+
public string TemplateSpecId { get; set; }
7777

7878
[Parameter(Position = 2, ParameterSetName = ParameterFileTemplateFileParameterSetName,
7979
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "Parameter file to use for the template")]
@@ -157,7 +157,7 @@ public override void ExecuteCmdlet()
157157
Name,
158158
Location,
159159
TemplateUri,
160-
TemplateSpec,
160+
TemplateSpecId,
161161
ParameterUri,
162162
parameters,
163163
Description,

‎src/Resources/ResourceManager/Implementation/DeploymentStacks/RemoveAzResourceGroupDeploymentStackSnapshot.cs

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,17 @@ public class RemoveAzResourceGroupDeploymentStackSnapshot : DeploymentStacksCmdl
3030
internal const string RemoveByResourceIdParameterSetName = "RemoveByResourceId";
3131
internal const string RemoveByResourceNameParameterSetname = "RemoveByResourceName";
3232

33-
[Alias("StackName")]
33+
3434
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = RemoveByResourceNameParameterSetname,
3535
HelpMessage = "The name of the deploymentStack to delete")]
3636
[ValidateNotNullOrEmpty]
37-
public string Name { get; set; }
37+
public string StackName { get; set; }
3838

39+
[Alias("SnapshotName")]
3940
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = RemoveByResourceNameParameterSetname,
4041
HelpMessage = "The name of the deploymentStack snapshot to delete")]
4142
[ValidateNotNullOrEmpty]
42-
public string SnapshotName { get; set; }
43+
public string Name { get; set; }
4344

4445
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = RemoveByResourceNameParameterSetname,
4546
HelpMessage = "The name of the Resource Group with the stack to delete")]
@@ -68,22 +69,22 @@ public override void ExecuteCmdlet()
6869
: null;
6970

7071
ResourceGroupName = ResourceGroupName ?? resourceIdentifier.ResourceGroupName;
71-
Name = Name ?? ResourceIdUtility.GetResourceName(ResourceId);
72+
StackName = StackName ?? ResourceIdUtility.GetResourceName(ResourceId);
7273

73-
if(ResourceId != null && SnapshotName == null)
74+
if(ResourceId != null && Name == null)
7475
{
75-
Name = Name.Split('/')[0];
76-
SnapshotName = resourceIdentifier.ResourceName;
76+
StackName = StackName.Split('/')[0];
77+
Name = resourceIdentifier.ResourceName;
7778
}
7879

79-
string confirmationMessage = $"Are you sure you want to remove snapshot '{SnapshotName}' of DeploymentStack '{Name}'";
80+
string confirmationMessage = $"Are you sure you want to remove snapshot '{Name}' of DeploymentStack '{StackName}'";
8081

8182
ConfirmAction(
8283
Force.IsPresent,
8384
confirmationMessage,
8485
"Deleting Deployment Stack Snapshot...",
8586
Name,
86-
() => DeploymentStacksSdkClient.DeleteResourceGroupDeploymentStackSnapshot(ResourceGroupName, Name, SnapshotName)
87+
() => DeploymentStacksSdkClient.DeleteResourceGroupDeploymentStackSnapshot(ResourceGroupName, StackName, Name)
8788
);
8889

8990
WriteObject(true);

‎src/Resources/ResourceManager/Implementation/DeploymentStacks/RemoveAzSubscriptionDeploymentStackSnapshot.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,16 @@ public class RemoveAzSubscriptionDeploymentStackSnapshot : DeploymentStacksCmdle
3030
internal const string RemoveByResourceIdParameterSetName = "RemoveByResourceId";
3131
internal const string RemoveByResourceNameParameterSetname = "RemoveByResourceName";
3232

33-
[Alias("StackName")]
3433
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = RemoveByResourceNameParameterSetname,
3534
HelpMessage = "The name of the deploymentStack to delete")]
3635
[ValidateNotNullOrEmpty]
37-
public string Name { get; set; }
36+
public string StackName { get; set; }
3837

38+
[Alias("SnapshotName")]
3939
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = RemoveByResourceNameParameterSetname,
4040
HelpMessage = "The name of the deploymentStack snapshot to delete")]
4141
[ValidateNotNullOrEmpty]
42-
public string SnapshotName { get; set; }
42+
public string Name { get; set; }
4343

4444
[Alias("Id")]
4545
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, ParameterSetName = RemoveByResourceIdParameterSetName,
@@ -62,22 +62,22 @@ public override void ExecuteCmdlet()
6262
? new ResourceIdentifier(ResourceId)
6363
: null;
6464

65-
Name = Name ?? ResourceIdUtility.GetResourceName(ResourceId);
65+
StackName = StackName ?? ResourceIdUtility.GetResourceName(ResourceId);
6666

67-
if (ResourceId != null && SnapshotName == null)
67+
if (ResourceId != null && Name == null)
6868
{
69-
Name = Name.Split('/')[0];
70-
SnapshotName = resourceIdentifier.ResourceName;
69+
StackName = StackName.Split('/')[0];
70+
Name = resourceIdentifier.ResourceName;
7171
}
7272

73-
string confirmationMessage = $"Are you sure you want to remove snapshot '{SnapshotName}' of DeploymentStack '{Name}'";
73+
string confirmationMessage = $"Are you sure you want to remove snapshot '{Name}' of DeploymentStack '{StackName}'";
7474

7575
ConfirmAction(
7676
Force.IsPresent,
7777
confirmationMessage,
7878
"Deleting Deployment Stack Snapshot...",
79-
SnapshotName,
80-
() => DeploymentStacksSdkClient.DeleteSubscriptionDeploymentStackSnapshot(Name, SnapshotName)
79+
Name,
80+
() => DeploymentStacksSdkClient.DeleteSubscriptionDeploymentStackSnapshot(StackName, Name)
8181
);
8282

8383
WriteObject(true);

‎src/Resources/ResourceManager/Implementation/DeploymentStacks/SetAzResourceGroupDeploymentStack.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public class SetAzResourceGroupDeploymentStack : DeploymentStacksCmdletBase
7979
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "ResourceId of the TemplateSpec to be used to create the stack")]
8080
[Parameter(Position = 2, ParameterSetName = ParameterlessTemplateSpecParameterSetName,
8181
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "ResourceId of the TemplateSpec to be used to create the stack")]
82-
public string TemplateSpec { get; set; }
82+
public string TemplateSpecId { get; set; }
8383

8484
[Parameter(Position = 3, ParameterSetName = ParameterFileTemplateFileParameterSetName,
8585
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "Parameter file to use for the template")]
@@ -159,7 +159,7 @@ public override void ExecuteCmdlet()
159159
Name,
160160
ResourceGroupName,
161161
TemplateUri,
162-
TemplateSpec,
162+
TemplateSpecId,
163163
ParameterUri,
164164
parameters,
165165
Description,

‎src/Resources/ResourceManager/Implementation/DeploymentStacks/SetAzSubscriptionDeploymentStack.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public class SetAzSubscriptionDeploymentStack : DeploymentStacksCmdletBase
7373
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "ResourceId of the TemplateSpec to be used to create the stack")]
7474
[Parameter(Position = 1, ParameterSetName = ParameterlessTemplateSpecParameterSetName,
7575
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "ResourceId of the TemplateSpec to be used to create the stack")]
76-
public string TemplateSpec { get; set; }
76+
public string TemplateSpecId { get; set; }
7777

7878
[Parameter(Position = 2, ParameterSetName = ParameterFileTemplateFileParameterSetName,
7979
Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "Parameter file to use for the template")]
@@ -157,7 +157,7 @@ public override void ExecuteCmdlet()
157157
Name,
158158
Location,
159159
TemplateUri,
160-
TemplateSpec,
160+
TemplateSpecId,
161161
ParameterUri,
162162
parameters,
163163
Description,

‎src/Resources/ResourceManager/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
[assembly: ComVisible(false)]
2626
[assembly: CLSCompliant(false)]
2727
[assembly: Guid("e8f34267-c461-4eae-b156-5f3528553d10")]
28-
[assembly: AssemblyVersion("4.2.8")]
29-
[assembly: AssemblyFileVersion("4.2.8")]
28+
[assembly: AssemblyVersion("4.2.9")]
29+
[assembly: AssemblyFileVersion("4.2.9")]
3030
#if !SIGN
3131
[assembly: InternalsVisibleTo("Microsoft.Azure.PowerShell.Cmdlets.Resources.Test")]
3232
[assembly: InternalsVisibleTo("Microsoft.Azure.PowerShell.Cmdlets.MachineLearning.Test")]

‎src/Resources/ResourceManager/SdkClient/DeploymentStacksSdkClient.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -385,17 +385,17 @@ internal void DeleteResourceGroupDeploymentStackSnapshot(string resourceGroupNam
385385
return;
386386
}
387387

388-
internal void DeleteSubscriptionDeploymentStackSnapshot(string name, string snapshotName)
388+
internal void DeleteSubscriptionDeploymentStackSnapshot(string stackname, string snapshotName)
389389
{
390390
var deleteResponse = DeploymentStacksClient.DeploymentStackSnapshots
391-
.DeleteAtSubscriptionWithHttpMessagesAsync(name, snapshotName)
391+
.DeleteAtSubscriptionWithHttpMessagesAsync(stackname, snapshotName)
392392
.GetAwaiter()
393393
.GetResult();
394394

395395
if (deleteResponse.Response.StatusCode == System.Net.HttpStatusCode.NoContent)
396396
{
397397
throw new PSArgumentException(
398-
$"DeploymentStack snapshot '{snapshotName}' of the DeploymentStack '{name}' not found."
398+
$"DeploymentStack snapshot '{snapshotName}' of the DeploymentStack '{stackname}' not found."
399399
);
400400
}
401401

‎src/Resources/Resources/Az.Resources.psd1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# RootModule = ''
1313

1414
# Version number of this module.
15-
ModuleVersion = '4.2.8'
15+
ModuleVersion = '4.2.9'
1616

1717
# Supported PSEditions
1818
CompatiblePSEditions = 'Core', 'Desktop'

0 commit comments

Comments
 (0)