Skip to content

Commit 2169f52

Browse files
dpkp88manpreet
authored andcommitted
Follow-up to dpkp#1068: remove not-implemented comments
1 parent 45642af commit 2169f52

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

kafka/consumer/group.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ class KafkaConsumer(six.Iterator):
254254
'ssl_password': None,
255255
'api_version': None,
256256
'api_version_auto_timeout_ms': 2000,
257-
'connections_max_idle_ms': 9 * 60 * 1000, # Not implemented yet
257+
'connections_max_idle_ms': 9 * 60 * 1000,
258258
'metric_reporters': [],
259259
'metrics_num_samples': 2,
260260
'metrics_sample_window_ms': 30000,

kafka/producer/kafka.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ class KafkaProducer(object):
265265
'linger_ms': 0,
266266
'partitioner': DefaultPartitioner(),
267267
'buffer_memory': 33554432,
268-
'connections_max_idle_ms': 9 * 60 * 1000, # not implemented yet
268+
'connections_max_idle_ms': 9 * 60 * 1000,
269269
'max_block_ms': 60000,
270270
'max_request_size': 1048576,
271271
'metadata_max_age_ms': 300000,

0 commit comments

Comments
 (0)