Skip to content

Commit 97f25b8

Browse files
dpkp88manpreet
authored andcommitted
Follow-up: support manual py26 testing; dont advertise 3.3 support
1 parent 058aa13 commit 97f25b8

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

setup.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import sys
21
import os
2+
import sys
3+
34
from setuptools import setup, Command, find_packages
45

56
# Pull version from source without importing
@@ -23,6 +24,8 @@ def run(cls):
2324

2425

2526
test_require = ['tox', 'mock']
27+
if sys.version_info < (2, 7):
28+
test_require.append('unittest2')
2629

2730
here = os.path.abspath(os.path.dirname(__file__))
2831

@@ -51,7 +54,6 @@ def run(cls):
5154
"Programming Language :: Python :: 2",
5255
"Programming Language :: Python :: 2.7",
5356
"Programming Language :: Python :: 3",
54-
"Programming Language :: Python :: 3.3",
5557
"Programming Language :: Python :: 3.4",
5658
"Programming Language :: Python :: 3.5",
5759
"Programming Language :: Python :: 3.6",

tox.ini

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist = py{27,34,35,36,py}, docs
2+
envlist = py{26,27,34,35,36,py}, docs
33

44
[pytest]
55
testpaths = kafka test
@@ -20,12 +20,17 @@ deps =
2020
python-snappy
2121
lz4==0.11.1
2222
xxhash
23+
py26: unittest2
2324
commands =
2425
py.test {posargs:--pylint --pylint-rcfile=pylint.rc --pylint-error-types=EF --cov=kafka --cov-config=.covrc}
2526
setenv =
2627
PROJECT_ROOT = {toxinidir}
2728
passenv = KAFKA_VERSION
2829

30+
[testenv:py26]
31+
# pylint doesn't support python2.6
32+
commands = py.test {posargs:--cov=kafka --cov-config=.covrc}
33+
2934
[testenv:pypy]
3035
# pylint is super slow on pypy...
3136
commands = py.test {posargs:--cov=kafka --cov-config=.covrc}

0 commit comments

Comments
 (0)