Skip to content

Commit 411192d

Browse files
committed
Reverts to default termination period, and uses bash for "shell form"...
as Alpine's /bin/busybox (ash) does not forward signals, according to https://pracucci.com/graceful-shutdown-of-kubernetes-pods.html The reason for the termination period change is that we haven't observed any termination behavior yet so we can't know how slow it might be.
1 parent e5ba57e commit 411192d

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

50kafka.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ spec:
1414
prometheus.io/scrape: "true"
1515
prometheus.io/port: "5556"
1616
spec:
17-
terminationGracePeriodSeconds: 10
17+
terminationGracePeriodSeconds: 30
1818
containers:
1919
- name: metrics
2020
image: solsson/kafka-prometheus-jmx-exporter@sha256:1f7c96c287a2dbec1d909cd8f96c0656310239b55a9a90d7fd12c81f384f1f7d
@@ -35,7 +35,7 @@ spec:
3535
ports:
3636
- containerPort: 9092
3737
command:
38-
- sh
38+
- /bin/bash
3939
- -c
4040
- >
4141
./bin/kafka-server-start.sh

zookeeper/50pzoo.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ spec:
1515
prometheus.io/scrape: "true"
1616
prometheus.io/port: "5556"
1717
spec:
18-
terminationGracePeriodSeconds: 10
18+
terminationGracePeriodSeconds: 30
1919
containers:
2020
- name: metrics
2121
image: solsson/kafka-prometheus-jmx-exporter@sha256:1f7c96c287a2dbec1d909cd8f96c0656310239b55a9a90d7fd12c81f384f1f7d
@@ -40,7 +40,7 @@ spec:
4040
- name: JMX_PORT
4141
value: "5555"
4242
command:
43-
- sh
43+
- /bin/bash
4444
- -c
4545
- >
4646
set -e;

zookeeper/51zoo.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ spec:
1515
prometheus.io/scrape: "true"
1616
prometheus.io/port: "5556"
1717
spec:
18-
terminationGracePeriodSeconds: 10
18+
terminationGracePeriodSeconds: 30
1919
containers:
2020
- name: metrics
2121
image: solsson/kafka-prometheus-jmx-exporter@sha256:1f7c96c287a2dbec1d909cd8f96c0656310239b55a9a90d7fd12c81f384f1f7d
@@ -40,7 +40,7 @@ spec:
4040
- name: JMX_PORT
4141
value: "5555"
4242
command:
43-
- sh
43+
- /bin/bash
4444
- -c
4545
- >
4646
set -e;

0 commit comments

Comments
 (0)