Skip to content

Commit 4c389e7

Browse files
committed
There's no reason to ever recommend auto.create.topics=true
I though that the feature would be neat for development (with replication factor 1, see #222) but it causes just as much confusion and useless troubleshooting there, for example race conditions between intentional topic creation and a container starting up to produce to the topic. You actually never know which topic config you're getting. Related: #107 The duplication is a workaround for kubernetes-sigs/kustomize#642
1 parent 527aa0d commit 4c389e7

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

variants/dev-small/auto-create-topics.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,5 @@
22
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
33
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "advertised.listeners=PLAINTEXT://:9092,OUTSIDE://localhost:9094"},
44
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
5-
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "auto.create.topics.enable=true"},
6-
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
75
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "num.partitions=1"}
86
]

variants/dev-small/listener-localhost.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,5 @@
22
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
33
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "advertised.listeners=PLAINTEXT://:9092,OUTSIDE://localhost:9094"},
44
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
5-
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "auto.create.topics.enable=true"},
6-
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
75
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "num.partitions=1"}
86
]

0 commit comments

Comments
 (0)