Skip to content

Commit e5a7644

Browse files
committed
Revert "[mlir][test] Shard the Test Dialect (NFC) (llvm#89628)"
This reverts commit ae22ac9.
1 parent 08d65dd commit e5a7644

File tree

4 files changed

+17
-20
lines changed

4 files changed

+17
-20
lines changed

mlir/test/lib/Dialect/Test/CMakeLists.txt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ mlir_tablegen(TestOpEnums.cpp.inc -gen-enum-defs)
3131
add_public_tablegen_target(MLIRTestEnumDefIncGen)
3232

3333
set(LLVM_TARGET_DEFINITIONS TestOps.td)
34+
mlir_tablegen(TestOps.h.inc -gen-op-decls)
35+
mlir_tablegen(TestOps.cpp.inc -gen-op-defs)
3436
mlir_tablegen(TestOpsDialect.h.inc -gen-dialect-decls -dialect=test)
3537
mlir_tablegen(TestOpsDialect.cpp.inc -gen-dialect-defs -dialect=test)
3638
mlir_tablegen(TestPatterns.inc -gen-rewriters)
@@ -41,8 +43,6 @@ mlir_tablegen(TestOpsSyntax.h.inc -gen-op-decls)
4143
mlir_tablegen(TestOpsSyntax.cpp.inc -gen-op-defs)
4244
add_public_tablegen_target(MLIRTestOpsSyntaxIncGen)
4345

44-
add_sharded_ops(TestOps 20)
45-
4646
# Exclude tests from libMLIR.so
4747
add_mlir_library(MLIRTestDialect
4848
TestAttributes.cpp
@@ -56,7 +56,6 @@ add_mlir_library(MLIRTestDialect
5656
TestTypes.cpp
5757
TestOpsSyntax.cpp
5858
TestDialectInterfaces.cpp
59-
${SHARDED_SRCS}
6059

6160
EXCLUDE_FROM_LIBMLIR
6261

@@ -67,7 +66,6 @@ add_mlir_library(MLIRTestDialect
6766
MLIRTestTypeDefIncGen
6867
MLIRTestOpsIncGen
6968
MLIRTestOpsSyntaxIncGen
70-
MLIRTestOpsShardGen
7169

7270
LINK_LIBS PUBLIC
7371
MLIRControlFlowInterfaces

mlir/test/lib/Dialect/Test/TestDialect.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,9 +325,12 @@ struct TestOpEffectInterfaceFallback
325325
void TestDialect::initialize() {
326326
registerAttributes();
327327
registerTypes();
328+
addOperations<
329+
#define GET_OP_LIST
330+
#include "TestOps.cpp.inc"
331+
>();
328332
registerOpsSyntax();
329333
addOperations<ManualCppOpWithFold>();
330-
registerTestDialectOperations(this);
331334
registerDynamicOp(getDynamicGenericOp(this));
332335
registerDynamicOp(getDynamicOneOperandTwoResultsOp(this));
333336
registerDynamicOp(getDynamicCustomParserPrinterOp(this));

mlir/test/lib/Dialect/Test/TestOps.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,5 @@
1414
using namespace mlir;
1515
using namespace test;
1616

17+
#define GET_OP_CLASSES
1718
#include "TestOps.cpp.inc"

utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
66
load("//llvm:lit_test.bzl", "package_path")
7-
load("//mlir:tblgen.bzl", "gentbl_cc_library", "td_library", "gentbl_sharded_ops", "td_library")
7+
load("//mlir:tblgen.bzl", "gentbl_cc_library", "td_library")
88

99
package(
1010
default_visibility = ["//visibility:public"],
@@ -153,6 +153,14 @@ gentbl_cc_library(
153153
name = "TestOpsIncGen",
154154
strip_include_prefix = "lib/Dialect/Test",
155155
tbl_outs = [
156+
(
157+
["-gen-op-decls"],
158+
"lib/Dialect/Test/TestOps.h.inc",
159+
),
160+
(
161+
["-gen-op-defs"],
162+
"lib/Dialect/Test/TestOps.cpp.inc",
163+
),
156164
(
157165
[
158166
"-gen-dialect-decls",
@@ -370,25 +378,12 @@ cc_library(
370378
],
371379
)
372380

373-
gentbl_sharded_ops(
374-
name = "TestDialectOpSrcs",
375-
hdr_out = "lib/Dialect/Test/TestOps.h.inc",
376-
shard_count = 20,
377-
sharder = "//mlir:mlir-src-sharder",
378-
src_file = "lib/Dialect/Test/TestOps.cpp",
379-
src_out = "lib/Dialect/Test/TestOps.cpp.inc",
380-
tblgen = "//mlir:mlir-tblgen",
381-
td_file = "lib/Dialect/Test/TestOps.td",
382-
test = True,
383-
deps = [":TestOpTdFiles"],
384-
)
385-
386381
cc_library(
387382
name = "TestDialect",
388383
srcs = glob(
389384
["lib/Dialect/Test/*.cpp"],
390385
exclude = ["lib/Dialect/Test/TestToLLVMIRTranslation.cpp"],
391-
) + [":TestDialectOpSrcs"],
386+
),
392387
hdrs = glob(["lib/Dialect/Test/*.h"]),
393388
includes = [
394389
"lib/Dialect/Test",

0 commit comments

Comments
 (0)