Skip to content

Commit e7c56d8

Browse files
65436543
andcommitted
fix ineffassign in Tests & set Version v0.13.0 (#345)
increment version fix ineffassign Co-authored-by: 6543 <[email protected]> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/345 Reviewed-by: Lunny Xiao <[email protected]> Reviewed-by: Andrew Thornton <[email protected]>
1 parent 567d2f8 commit e7c56d8

File tree

6 files changed

+8
-1
lines changed

6 files changed

+8
-1
lines changed

gitea/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ var jsonHeader = http.Header{"content-type": []string{"application/json"}}
2222

2323
// Version return the library version
2424
func Version() string {
25-
return "0.12.0"
25+
return "0.13.0"
2626
}
2727

2828
// Client represents a Gitea API client.

gitea/issue_comment_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ func TestIssueComment(t *testing.T) {
2222
repo, err := createTestRepo(t, "TestIssueCommentRepo", c)
2323
assert.NoError(t, err)
2424
issue1, err := c.CreateIssue(user.UserName, repo.Name, CreateIssueOption{Title: "issue1", Body: "body", Closed: false})
25+
assert.NoError(t, err)
2526
assert.EqualValues(t, 1, issue1.Index)
2627
issue2, err := c.CreateIssue(user.UserName, repo.Name, CreateIssueOption{Title: "issue1", Body: "body", Closed: false})
2728
assert.EqualValues(t, 2, issue2.Index)

gitea/issue_milestone_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,6 @@ func TestMilestones(t *testing.T) {
5353
_, err = c.GetMilestone(repo.Owner.UserName, repo.Name, m4.ID)
5454
assert.Error(t, err)
5555
m, err := c.GetMilestone(repo.Owner.UserName, repo.Name, m1.ID)
56+
assert.NoError(t, err)
5657
assert.EqualValues(t, m1, m)
5758
}

gitea/org_member_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ func TestOrgMembership(t *testing.T) {
3636
assert.True(t, check)
3737

3838
err = c.SetPublicOrgMembership(newOrg.UserName, user.UserName, true)
39+
assert.NoError(t, err)
3940
check, err = c.CheckPublicOrgMembership(newOrg.UserName, user.UserName)
4041
assert.NoError(t, err)
4142
assert.True(t, check)

gitea/pull_review_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ func TestPullReview(t *testing.T) {
5858
},
5959
},
6060
})
61+
assert.NoError(t, err)
62+
assert.NotNil(t, r3)
6163

6264
// ListPullReviews
6365
c.SetSudo("")

gitea/pull_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ func TestPull(t *testing.T) {
104104
Title: "confl",
105105
State: &state,
106106
})
107+
assert.NoError(t, err)
108+
assert.EqualValues(t, state, pr.State)
107109

108110
pulls, err = c.ListRepoPullRequests(user.UserName, repoName, ListPullRequestsOptions{
109111
State: StateClosed,

0 commit comments

Comments
 (0)