Skip to content

Commit d33e07b

Browse files
SomberNightaccumulator
authored andcommitted
build: add --android-target-sdk-version arg (defaults to android_api)
This allows setting the targetSdkVersion and compileSdkVersion independently.
1 parent 9907c9c commit d33e07b

File tree

7 files changed

+12
-6
lines changed

7 files changed

+12
-6
lines changed

pythonforandroid/bootstraps/common/build/build.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -545,6 +545,9 @@ def make_package(args):
545545
sdk_dir = fileh.read().strip()
546546
sdk_dir = sdk_dir[8:]
547547

548+
if args.android_target_sdk_version == -1:
549+
args.android_target_sdk_version = android_api
550+
548551
# Try to build with the newest available build tools
549552
ignored = {".DS_Store", ".ds_store"}
550553
build_tools_versions = [x for x in listdir(join(sdk_dir, 'build-tools')) if x not in ignored]
@@ -846,6 +849,9 @@ def parse_args_and_make_package(args=None):
846849
action='store_true',
847850
help=('Allow the --minsdk argument to be different from '
848851
'the discovered ndk_api in the dist'))
852+
ap.add_argument('--android-target-sdk-version', dest='android_target_sdk_version',
853+
default=-1, type=int,
854+
help='targetSdkVersion to put in manifest. Matches android-api by default.')
849855
ap.add_argument('--intent-filters', dest='intent_filters',
850856
help=('Add intent-filters xml rules to the '
851857
'AndroidManifest.xml file. The argument is a '

pythonforandroid/bootstraps/common/build/templates/build.tmpl.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ android {
3838
buildToolsVersion '{{ build_tools_version }}'
3939
defaultConfig {
4040
minSdkVersion {{ args.min_sdk_version }}
41-
targetSdkVersion {{ android_api }}
41+
targetSdkVersion {{ args.android_target_sdk_version }}
4242
versionCode {{ args.numeric_version }}
4343
versionName '{{ args.version }}'
4444
manifestPlaceholders = {{ args.manifest_placeholders}}

pythonforandroid/bootstraps/qt5/build/templates/AndroidManifest.tmpl.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
/>
2020

2121
<!-- Android 2.3.3 -->
22-
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ android_api }}" />
22+
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ args.android_target_sdk_version }}" />
2323

2424
<!-- OpenGL ES 2.0 -->
2525
<uses-feature android:glEsVersion="0x00020000" />

pythonforandroid/bootstraps/sdl2/build/templates/AndroidManifest.tmpl.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
/>
2020

2121
<!-- Android 2.3.3 -->
22-
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ android_api }}" />
22+
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ args.android_target_sdk_version }}" />
2323

2424
<!-- OpenGL ES 2.0 -->
2525
<uses-feature android:glEsVersion="0x00020000" />

pythonforandroid/bootstraps/service_library/build/templates/AndroidManifest.tmpl.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
android:versionName="{{ args.version }}">
66

77
<!-- Android 2.3.3 -->
8-
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ android_api }}" />
8+
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ args.android_target_sdk_version }}" />
99

1010
<application {% if debug %}android:debuggable="true"{% endif %} >
1111
{% for name in service_names %}

pythonforandroid/bootstraps/service_only/build/templates/AndroidManifest.tmpl.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
/>
1717

1818
<!-- Android 2.3.3 -->
19-
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ android_api }}" />
19+
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ args.android_target_sdk_version }}" />
2020

2121
<!-- Set permissions -->
2222
{% for perm in args.permissions %}

pythonforandroid/bootstraps/webview/build/templates/AndroidManifest.tmpl.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
/>
1717

1818
<!-- Android 2.3.3 -->
19-
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ android_api }}" />
19+
<uses-sdk android:minSdkVersion="{{ args.min_sdk_version }}" android:targetSdkVersion="{{ args.android_target_sdk_version }}" />
2020

2121
<!-- Allow writing to external storage -->
2222
<uses-permission android:name="android.permission.INTERNET" />

0 commit comments

Comments
 (0)