Skip to content

Commit 5ccd43a

Browse files
authored
Merge pull request swiftlang#188 from ddunbar/64bit-tracing-apis
[Basic] Adjust tracing APIs to accept 64-bit values.
2 parents d868de9 + e7b59da commit 5ccd43a

File tree

2 files changed

+20
-16
lines changed

2 files changed

+20
-16
lines changed

include/llbuild/Basic/Tracing.h

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@ enum class EngineQueueItemKind {
6262
/// An RAII type to define an individual tracing point.
6363
struct TracingPoint {
6464
const uint32_t kind;
65-
const uint32_t arg1;
66-
const uint32_t arg2;
67-
const uint32_t arg3;
68-
const uint32_t arg4;
65+
const uint64_t arg1;
66+
const uint64_t arg2;
67+
const uint64_t arg3;
68+
const uint64_t arg4;
6969

70-
TracingPoint(TraceEventKind kind, uint32_t arg1 = 0, uint32_t arg2 = 0,
71-
uint32_t arg3 = 0, uint32_t arg4 = 0)
70+
TracingPoint(TraceEventKind kind, uint64_t arg1 = 0, uint64_t arg2 = 0,
71+
uint64_t arg3 = 0, uint64_t arg4 = 0)
7272
: kind(uint32_t(kind)), arg1(arg1), arg2(arg2), arg3(arg3), arg4(arg4)
7373
{
7474
}
@@ -81,13 +81,13 @@ struct TracingPoint {
8181
/// interval completion event.
8282
struct TracingInterval {
8383
const uint32_t kind;
84-
uint32_t arg1;
85-
uint32_t arg2;
86-
uint32_t arg3;
87-
uint32_t arg4;
84+
uint64_t arg1;
85+
uint64_t arg2;
86+
uint64_t arg3;
87+
uint64_t arg4;
8888

89-
TracingInterval(TraceEventKind kind, uint32_t arg1 = 0, uint32_t arg2 = 0,
90-
uint32_t arg3 = 0, uint32_t arg4 = 0)
89+
TracingInterval(TraceEventKind kind, uint64_t arg1 = 0, uint64_t arg2 = 0,
90+
uint64_t arg3 = 0, uint64_t arg4 = 0)
9191
: kind(uint32_t(kind)), arg1(arg1), arg2(arg2), arg3(arg3), arg4(arg4)
9292
{
9393
}
@@ -97,10 +97,10 @@ struct TracingInterval {
9797
// MARK: Utility Wrappers
9898

9999
TracingInterval(EngineTaskCallbackKind arg1)
100-
: TracingInterval(TraceEventKind::EngineTaskCallback, uint32_t(arg1)) {}
100+
: TracingInterval(TraceEventKind::EngineTaskCallback, uint64_t(arg1)) {}
101101

102102
TracingInterval(EngineQueueItemKind arg1)
103-
: TracingInterval(TraceEventKind::EngineQueueItemEvent, uint32_t(arg1)) {}
103+
: TracingInterval(TraceEventKind::EngineQueueItemEvent, uint64_t(arg1)) {}
104104
};
105105

106106
/// An RAII type to define a string.
@@ -109,12 +109,12 @@ struct TracingString {
109109

110110
/// The integer code for the string, which can be provided to a trace point or
111111
/// interval.
112-
const uint32_t value;
112+
const uint64_t value;
113113

114114
TracingString(TraceEventKind kind, llvm::StringRef str)
115115
: kind(uint32_t(kind)), value(0) {}
116116

117-
operator uint32_t() const { return value; }
117+
operator uint64_t() const { return value; }
118118
};
119119

120120
}

llbuild.xcodeproj/project.pbxproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -761,6 +761,8 @@
761761
E17C29F21B5AC18C00C12DA9 /* install-user-sphinx.sh */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.sh; path = "install-user-sphinx.sh"; sourceTree = "<group>"; };
762762
E17C29F31B5AC2A700C12DA9 /* build-sphinx-docs.sh */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.sh; path = "build-sphinx-docs.sh"; sourceTree = "<group>"; };
763763
E18043391A00129400662FE7 /* install-user-lit.sh */ = {isa = PBXFileReference; lastKnownFileType = text.script.sh; path = "install-user-lit.sh"; sourceTree = "<group>"; };
764+
E181D1441F7D90AC0015286C /* Stat.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Stat.h; sourceTree = "<group>"; };
765+
E181D1451F7D90AC0015286C /* Tracing.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Tracing.h; sourceTree = "<group>"; };
764766
E182BE111ABA2B8D001840AD /* Compiler.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = Compiler.h; sourceTree = "<group>"; };
765767
E192E92E1E30014E00122F17 /* BuildValueTest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = BuildValueTest.cpp; sourceTree = "<group>"; };
766768
E19C3FD51B98C1A70035E1AA /* tests */ = {isa = PBXFileReference; lastKnownFileType = folder; path = tests; sourceTree = "<group>"; };
@@ -1429,6 +1431,8 @@
14291431
9D2589301E3820E3006C76F4 /* PlatformUtility.h */,
14301432
E147DEFC1BA81D0E0032D08E /* SerialQueue.h */,
14311433
E17440C11CE192E30070A30C /* ShellUtility.h */,
1434+
E181D1441F7D90AC0015286C /* Stat.h */,
1435+
E181D1451F7D90AC0015286C /* Tracing.h */,
14321436
E1A2245119F997D40059043E /* Version.h */,
14331437
);
14341438
name = Headers;

0 commit comments

Comments
 (0)