Skip to content

Update example for URL.can_parse #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

Update example for URL.can_parse #12

merged 1 commit into from
Jun 1, 2023

Conversation

bbayles
Copy link
Collaborator

@bbayles bbayles commented Jun 1, 2023

This PR fixes a mistake in the docstring for ada_url.URL.can_parse. The base and url arguments were reversed.

anonrig
anonrig approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bbayles bbayles merged commit c7446e4 into main Jun 1, 2023
@bbayles bbayles deleted the 20230601-comment branch June 1, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbayles @anonrig