Addressing PR comments

Author: scirelli

.gitignore

@@ -37,6 +37,7 @@ _build
 
 # Virtual environment-specific files
 .env
+.venv
 
 # MacOS-specific files
 *.DS_Store
@@ -45,4 +46,3 @@ _build
 .idea
 .vscode
 *~
-.env

adafruit_ads1x15/ads1015.py

@@ -11,7 +11,13 @@
 * Author(s): Carter Nelson
 """
 import struct
-from typing import Dict, List
+
+try:
+    from typing import Dict, List
+
+    from typing_extensions import Literal
+except ImportError:
+    pass
 
 # pylint: disable=unused-import
 from .ads1x15 import ADS1x15, Mode
@@ -42,7 +48,7 @@ class ADS1015(ADS1x15):
     """Class for the ADS1015 12 bit ADC."""
 
     @property
-    def bits(self) -> int:
+    def bits(self) -> Literal[12]:
         """The ADC bit resolution."""
         return 12
 

adafruit_ads1x15/ads1115.py

@@ -11,7 +11,13 @@
 * Author(s): Carter Nelson
 """
 import struct
-from typing import Dict, List
+
+try:
+    from typing import Dict, List
+
+    from typing_extensions import Literal
+except ImportError:
+    pass
 
 # pylint: disable=unused-import
 from .ads1x15 import ADS1x15, Mode
@@ -43,7 +49,7 @@ class ADS1115(ADS1x15):
     """Class for the ADS1115 16 bit ADC."""
 
     @property
-    def bits(self) -> int:
+    def bits(self) -> Literal[16]:
         """The ADC bit resolution."""
         return 16
 

adafruit_ads1x15/ads1x15.py

@@ -20,7 +20,7 @@
 from micropython import const
 
 try:
-    from typing import Optional, List, Dict
+    from typing import Dict, List, Literal, Optional, Union
 
     from busio import I2C
     from microcontroller import Pin
@@ -77,16 +77,16 @@ def __init__(
         # pylint: disable=too-many-arguments
         self._last_pin_read = None
         self.buf = bytearray(3)
-        self._gain: float
+        self._gain = gain
         self.gain = gain
-        self._data_rate: int
+        self._data_rate = self._data_rate_default() if data_rate is None else data_rate
         self.data_rate = self._data_rate_default() if data_rate is None else data_rate
-        self._mode: int
+        self._mode = mode
         self.mode = mode
         self.i2c_device = I2CDevice(i2c, address)
 
     @property
-    def bits(self) -> int:
+    def bits(self) -> Union[Literal[12], Literal[16]]:
         """The ADC bit resolution."""
         raise NotImplementedError("Subclass must implement bits property.")
 

requirements.txt

@@ -4,3 +4,4 @@
 
 Adafruit-Blinka
 adafruit-circuitpython-busdevice
+typing-extensions~=4.0