Skip to content

Commit 7d9f502

Browse files
authored
Merge pull request #8 from dhalbert/match_prefixes
prefix -> match_prefixes
2 parents 2a49010 + e568999 commit 7d9f502

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

adafruit_ble_eddystone/__init__.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def __set__(self, obj, value):
106106
class EddystoneAdvertisement(Advertisement):
107107
"""Top level Eddystone advertisement that manages frame type. For library use only."""
108108

109-
# Subclasses must provide `prefix`.
109+
# Subclasses must provide `match_prefixes`.
110110
services = ServiceList(standard_services=[0x03], vendor_services=[0x07])
111111
eddystone_frame = _EddystoneFrame()
112112

@@ -116,17 +116,10 @@ def __init__(self, *, minimum_size=None):
116116
self.connectable = False
117117
self.flags.general_discovery = True
118118
self.flags.le_only = True
119-
self.frame_type = bytearray(1)
120-
# Frame type is in the prefix.
121-
self.frame_type[0] = self.prefix[-1]
119+
# self.frame_type is defined by the subclass.
122120
if not self.eddystone_frame:
123121
self.eddystone_frame = bytearray(minimum_size)
124122

125-
@classmethod
126-
def matches(cls, entry):
127-
"""True if the entry matches all of the prefixes. This is stricter than the scan."""
128-
return entry.matches(cls.prefix, all=True)
129-
130123
def __str__(self):
131124
parts = []
132125
for attr in dir(self.__class__):

adafruit_ble_eddystone/uid.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ class EddystoneUID(EddystoneAdvertisement):
4242
:param int tx_power: TX power at the beacon
4343
"""
4444

45-
prefix = b"\x03\x03\xaa\xfe\x04\x16\xaa\xfe\x00"
45+
match_prefixes = (b"\x03\xaa\xfe", b"\x16\xaa\xfe\x00")
46+
frame_type = b"\x00"
4647

4748
tx_power = EddystoneFrameStruct("<B", offset=0)
4849
"""TX power at the beacon in dBm"""

adafruit_ble_eddystone/url.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ class EddystoneURL(EddystoneAdvertisement):
9696
:param str url: Target url
9797
:param int tx_power: TX power in dBm"""
9898

99-
prefix = b"\x03\x03\xaa\xfe\x04\x16\xaa\xfe\x10"
99+
match_prefixes = (b"\x03\xaa\xfe", b"\x16\xaa\xfe\x10")
100+
frame_type = b"\x10"
100101
tx_power = EddystoneFrameStruct("<B", offset=0)
101102
"""TX power in dBm"""
102103

0 commit comments

Comments
 (0)