Skip to content

Commit 921d4f0

Browse files
committed
Remove unnecessary 'if' and 'else' in the pressure property
This causes a change in behavior when var1 == 0. Previously, the property would return 0. Now it returns _BMP280_PRESSURE_MIN_HPA. The new behavior is the same as in the Bosch C driver. This also makes pylint happy by remove the 'return after else'
1 parent e3bc8af commit 921d4f0

File tree

1 file changed

+12
-16
lines changed

1 file changed

+12
-16
lines changed

adafruit_bmp280.py

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -310,23 +310,19 @@ def pressure(self):
310310
var3 = self._pressure_calib[2] * var1 * var1 / 524288.0
311311
var1 = (var3 + self._pressure_calib[1] * var1) / 524288.0
312312
var1 = (1.0 + var1 / 32768.0) * self._pressure_calib[0]
313-
if var1 == 0:
314-
return 0
315-
if var1:
316-
pressure = 1048576.0 - adc
317-
pressure = ((pressure - var2 / 4096.0) * 6250.0) / var1
318-
var1 = self._pressure_calib[8] * pressure * pressure / 2147483648.0
319-
var2 = pressure * self._pressure_calib[7] / 32768.0
320-
pressure = pressure + (var1 + var2 + self._pressure_calib[6]) / 16.0
321-
322-
pressure /= 100
323-
if pressure < _BMP280_PRESSURE_MIN_HPA:
324-
return _BMP280_PRESSURE_MIN_HPA
325-
if pressure > _BMP280_PRESSURE_MAX_HPA:
326-
return _BMP280_PRESSURE_MAX_HPA
327-
return pressure
328-
else:
313+
if not var1:
329314
return _BMP280_PRESSURE_MIN_HPA
315+
pressure = 1048576.0 - adc
316+
pressure = ((pressure - var2 / 4096.0) * 6250.0) / var1
317+
var1 = self._pressure_calib[8] * pressure * pressure / 2147483648.0
318+
var2 = pressure * self._pressure_calib[7] / 32768.0
319+
pressure = pressure + (var1 + var2 + self._pressure_calib[6]) / 16.0
320+
pressure /= 100
321+
if pressure < _BMP280_PRESSURE_MIN_HPA:
322+
return _BMP280_PRESSURE_MIN_HPA
323+
if pressure > _BMP280_PRESSURE_MAX_HPA:
324+
return _BMP280_PRESSURE_MAX_HPA
325+
return pressure
330326

331327
@property
332328
def altitude(self):

0 commit comments

Comments
 (0)