Some code simplification

Author: rpavlik

adafruit_emc2101/emc2101_lut.py

@@ -127,8 +127,7 @@ def __repr__(self):
     def __str__(self):
         """return the official string representation of the LUT"""
         value_strs = []
-        lut_keys = list(self.lut_values.keys())
-        lut_keys.sort()
+        lut_keys = list(sorted(self.lut_values.keys()))
         for temp in lut_keys:
             fan_drive = self.lut_values[temp]
             value_strs.append("%d deg C => %.1f%% duty cycle" % (temp, fan_drive))
@@ -143,31 +142,26 @@ def __len__(self):
     # temperature first
 
     def _set_lut(self, lut_dict):
-        lut_keys = list(lut_dict.keys())
-        lut_size = len(lut_dict)
         # Make sure we're not going to try to set more entries than we have slots
-        if lut_size > 8:
+        if len(lut_dict) > 8:
             raise AttributeError("LUT can only contain a maximum of 8 items")
 
-        # we want to assign the lowest temperature to the lowest LUT slot, so we sort the keys/temps
-        for k in lut_keys:
-            # Verify that the value is a correct amount
-            lut_value = lut_dict[k]
-            if lut_value > 100.0 or lut_value < 0:
+        # Verify that the value is a correct amount
+        for speed in lut_dict.values():
+            if speed > 100.0 or speed < 0:
                 raise AttributeError("LUT values must be a fan speed from 0-100%")
 
-            # add the current temp/speed to our internal representation
-            self.lut_values[k] = lut_value
+        # Copy to our internal representation
+        self.lut_values = {k: v for k, v in lut_dict.items()}
         current_mode = self.emc_fan.lut_enabled
 
         # Disable the lut to allow it to be updated
         self.emc_fan.lut_enabled = False
 
+        # we want to assign the lowest temperature to the lowest LUT slot, so we sort the keys/temps
         # get and sort the new lut keys so that we can assign them in order
-        lut_keys = list(self.lut_values.keys())
-        lut_keys.sort()
-        for idx in range(lut_size):
-            current_temp = lut_keys[idx]
+        flat_list = []
+        for idx, current_temp in enumerate(sorted(self.lut_values.keys())):
             current_speed = _speed_to_lsb(self.lut_values[current_temp])
             getattr(self, "_fan_lut_t%d" % (idx + 1)).__set__(self, current_temp)
             getattr(self, "_fan_lut_s%d" % (idx + 1)).__set__(self, current_speed)
@@ -176,7 +170,7 @@ def _set_lut(self, lut_dict):
             # self.emc_fan._lut_speed_setters[idx].__set__(self.emc_fan, current_speed)
 
         # Set the remaining LUT entries to the default (Temp/Speed = max value)
-        for idx in range(8)[lut_size:]:
+        for idx in range(8)[len(self.lut_values):]:
             getattr(self, "_fan_lut_t%d" % (idx + 1)).__set__(self, MAX_LUT_TEMP)
             getattr(self, "_fan_lut_s%d" % (idx + 1)).__set__(self, MAX_LUT_SPEED)
         self.emc_fan.lut_enabled = current_mode