Skip to content

fix ping for esp8266 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2019
Merged

fix ping for esp8266 #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions adafruit_espatcontrol/adafruit_espatcontrol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,11 @@ def ping(self, host):
"""Ping the IP or hostname given, returns ms time or None on failure"""
reply = self.at_response('AT+PING="%s"' % host.strip('"'), timeout=5)
for line in reply.split(b'\r\n'):
if line and line.startswith(b'+PING:'):
if line and line.startswith(b'+'):
try:
return int(line[6:])
if line[1:5] == b'PING':
return int(line[6:])
return int(line[1:])
except ValueError:
return None
raise RuntimeError("Couldn't ping")
Expand Down