Add SMS #4
Merged
Add SMS #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
May 7, 2020 17:06
ladyada
requested changes
May 13, 2020
adafruit_fona/adafruit_fona.py
Outdated
| @@ -340,26 +335,19 @@ def network_status(self): | |||
| print("Network status") | |||
| if not self._send_parse_reply(b"AT+CREG?", b"+CREG: ", idx=1): | |||
| return False | |||
| if self._buf == 0: | |||
| # Not Registered | |||
| if self._buf == 0: # Not Registered | |||
There was a problem hiding this comment.
change to self._buf in (0, 1, 2, 3...) ??
added 2 commits
May 13, 2020 14:57
ladyada
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds SMS functionality for the FONA808:
send_sms: sends a sms message to a phone numbernum_sms: property to query sms messages stored in memory or SIMdelete_all_sms: deletes all sms messages on FONA SIMdelete_sms: deletes a sms message in provided slotread_sms: reads contents of sms message from a slot, returns phone number and sms messagefona_sms.py: sends SMS, queries sms messages on SIM, reads SMS messagesfona_sms.pyoutput