Skip to content

Fix type annotatations, minor tweaks #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 23, 2022
Merged

Fix type annotatations, minor tweaks #105

merged 18 commits into from
Sep 23, 2022

Conversation

tekktrik
Copy link
Member

  1. Fixes type annotations
  2. A couple minor non-functional tweaks for code improvement, like using for loop, enumerate, and making sure a variable was never unbound.

@tekktrik tekktrik linked an issue Sep 23, 2022 that may be closed by this pull request
Error setting individual Characters as numbers using Object as List #104
Closed
@tekktrik tekktrik changed the title Fix type annotatations Fix type annotatations, minor tweaks Sep 23, 2022
@tekktrik tekktrik marked this pull request as draft September 23, 2022 15:51
@tekktrik tekktrik marked this pull request as ready for review September 23, 2022 16:25
@tekktrik
Copy link
Member Author

Alright, fixed the issues I found in my submission (the joys of nighttime commits), ready for review @makermelissa!

makermelissa
makermelissa requested changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see marked comments. It's possible I may have missed more items.

makermelissa
makermelissa approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@tekktrik tekktrik merged commit 162daa3 into adafruit:main Sep 23, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 24, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@eaa233b)
f533444 
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.5.4 from 4.5.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#105 from tekktrik/doc/fix-type-annotatations

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.2.17 from 3.2.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#27 from tcfranks/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error setting individual Characters as numbers using Object as List
2 participants
@tekktrik @makermelissa