Skip to content

Use more specific error for discovering bridge_wifi #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Use more specific error for discovering bridge_wifi #21

merged 1 commit into from
Jul 27, 2022

Conversation

tekktrik
Copy link
Member

If the Hue isn't connected to the same network as the CircuitPython device, the payload is an empty list []. This updates the error handling to only catch that as the sign, and allow other errors to be raised so that other issues aren't mistakenly flagged as this.

Not tested, just checked the payload myself on my laptop to be sure.

@tekktrik tekktrik requested a review from a team July 27, 2022 03:14
@tekktrik tekktrik linked an issue Jul 27, 2022 that may be closed by this pull request
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 7662827 into adafruit:main Jul 27, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 28, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.4.0 from 3.3.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#72 from Neradoc/compatibility-rainbowio
  > Changed .env to .venv in README.rst
  > Removed duplicate-code from library pylint disable

Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.10.5 from 2.10.4:
  > Create requirements.txt
  > Changed .env to .venv in README.rst

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3MDL to 1.1.17 from 1.1.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3MDL#22 from adafruit/lsm6dstrc
  > Changed .env to .venv in README.rst

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 2.0.0 from 1.2.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#22 from caternuson/iss19
  > Changed .env to .venv in README.rst

Updating https://github.com/adafruit/Adafruit_CircuitPython_PN532 to 2.3.10 from 2.3.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_PN532#57 from tekktrik/doc/fix-product-link
  > Changed .env to .venv in README.rst
  > Removed duplicate-code from library pylint disable

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#6 from tekktrik/doc/add-product-link

Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.12 from 0.5.11:
  > Create requirements.txt

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.8 from 2.5.7:
  > Updated sphinx version
  > Changed .env to .venv in README.rst

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.3.4 from 8.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#168 from tekktrik/doc/add-type-annotations
  > Changed .env to .venv in README.rst
  > Removed duplicate-code from library pylint disable

Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 1.2.0 from 1.1.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_Hue#21 from tekktrik/dev/specific-error
  > Changed .env to .venv in README.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be more specific about error catching
2 participants