Merge pull request #1 from kattni/linty

Lint etc for release.

Author: kattni

adafruit_is31fl3741/__init__.py

@@ -76,15 +76,20 @@ def __init__(self, i2c, address=_IS3741_ADDR_DEFAULT):
         self._page = None
         self.reset()
 
-
     def reset(self):
+        """Reset"""
         self.page = 4
         self._reset_reg = 0xAE
 
     def unlock(self):
+        """Unlock"""
         self._lock_reg = 0xC5
 
     def set_led_scaling(self, scale):
+        """Set LED scaling.
+
+        param scale: The scale.
+        """
         scalebuf = [scale] * 181
         scalebuf[0] = 0
         self.page = 2
@@ -96,40 +101,40 @@ def set_led_scaling(self, scale):
 
     @property
     def global_current(self):
+        """Global current"""
         self.page = 4
         return self._gcurrent_reg
 
     @global_current.setter
-    def global_current(self, gc):
+    def global_current(self, current):
         self.page = 4
-        self._gcurrent_reg = gc
-        
+        self._gcurrent_reg = current
 
     @property
     def enable(self):
+        """Enable"""
         self.page = 4
         return self._shutdown_bit
 
     @enable.setter
-    def enable(self, en):
+    def enable(self, enable):
         self.page = 4
-        self._shutdown_bit = en
-        
+        self._shutdown_bit = enable
+
     @property
     def page(self):
+        """Page"""
         return self._page
 
     @page.setter
-    def page(self, p):
-        if p == self._page:
+    def page(self, page_value):
+        if page_value == self._page:
             return  # already set
-        if p > 4:
+        if page_value > 4:
             raise ValueError("Page must be 0 ~ 4")
-        self._page = p  # cache
+        self._page = page_value  # cache
         self.unlock()
-        self._page_reg = p
-
-
+        self._page_reg = page_value
 
     def __getitem__(self, led):
         if not 0 <= led <= 350:
@@ -142,18 +147,18 @@ def __getitem__(self, led):
             self._buf[0] = led - 180
 
         with self.i2c_device as i2c:
-            i2c.write_then_readinto(self._buf, self._buf,
-                                    out_start=0, out_end=1,
-                                    in_start=1, in_end=2)
+            i2c.write_then_readinto(
+                self._buf, self._buf, out_start=0, out_end=1, in_start=1, in_end=2
+            )
         return self._buf[1]
 
     def __setitem__(self, led, pwm):
         if not 0 <= led <= 350:
             raise ValueError("LED must be 0 ~ 350")
         if not 0 <= pwm <= 255:
             raise ValueError("PWM must be 0 ~ 255")
-        #print(led, pwm)
-        
+        # print(led, pwm)
+
         if led < 180:
             self.page = 0
             self._buf[0] = led
@@ -170,7 +175,6 @@ def pixel_addrs(x, y):
         """Calulate the offset into the device array for x,y pixel"""
         raise NotImplementedError("Supported in subclasses only")
 
-
     # pylint: disable-msg=too-many-arguments
     def pixel(self, x, y, color=None):
         """
@@ -185,7 +189,7 @@ def pixel(self, x, y, color=None):
         if not 0 <= y <= self.height:
             return None
         addrs = self.pixel_addrs(x, y)
-        #print(addrs)
+        # print(addrs)
         if color is not None:  # set the color
             self[addrs[0]] = (color >> 16) & 0xFF
             self[addrs[1]] = (color >> 8) & 0xFF
@@ -201,13 +205,11 @@ def pixel(self, x, y, color=None):
 
     # pylint: enable-msg=too-many-arguments
 
-    def image(self, img, blink=None, frame=None):
+    def image(self, img):
         """Set buffer to value of Python Imaging Library image.  The image should
         be in 8-bit mode (L) and a size equal to the display size.
 
         :param img: Python Imaging Library image
-        :param blink: True to blink
-        :param frame: the frame to set the image
         """
         if img.mode != "RGB":
             raise ValueError("Image must be in mode RGB.")

adafruit_is31fl3741/adafruit_rgbmatrixqt.py

@@ -47,26 +47,26 @@ def pixel_addrs(x, y):
 
         if row <= 5:
             if col < 10:
-                offset = 0x1E*row + col*3
+                offset = 0x1E * row + col * 3
             else:
-                offset = 0xB4 + 0x5A + 9*row + (col - 10)*3
+                offset = 0xB4 + 0x5A + 9 * row + (col - 10) * 3
         else:
             if col < 10:
-                offset = 0xB4 + (row-6)*0x1E + col*3
+                offset = 0xB4 + (row - 6) * 0x1E + col * 3
             else:
-                offset = 0xB4 + 0x5A + 9*row + (col - 10)*3
-            
-        #print(x, ",", y, "->", hex(offset))
+                offset = 0xB4 + 0x5A + 9 * row + (col - 10) * 3
+
+        # print(x, ",", y, "->", hex(offset))
         r_off = 0
         g_off = 1
         b_off = 2
         if col == 12 or col % 2 == 1:  # odds + last col
             r_off = 2
             g_off = 1
             b_off = 0
-        else: # evens
+        else:  # evens
             r_off = 0
             g_off = 2
             b_off = 1
-            
-        return (offset+r_off, offset+g_off, offset+b_off)
+
+        return (offset + r_off, offset + g_off, offset + b_off)

adafruit_is31fl3741/issi_evb.py

@@ -44,4 +44,4 @@ def pixel_addrs(x, y):
         else:
             offset = (x + y * 10) * 3
 
-        return (offset+2, offset+1, offset)
+        return (offset + 2, offset + 1, offset)

docs/conf.py

@@ -23,7 +23,7 @@
 # Uncomment the below if you use native CircuitPython modules such as
 # digitalio, micropython and busio. List the modules you use. Without it, the
 # autodoc module docs will fail to generate with a warning.
-# autodoc_mock_imports = ["micropython"]
+autodoc_mock_imports = ["adafruit_bus_device", "adafruit_register"]
 
 intersphinx_mapping = {
     "python": ("https://docs.python.org/3.4", None),

examples/is31fl3741_rgbswirl.py

@@ -1,30 +1,22 @@
-"""CircuitPython Essentials I2C Scan example"""
-# If you run this and it seems to hang, try manually unlocking
-# your I2C bus from the REPL with
-#  >>> import board
-#  >>> board.I2C().unlock()
+# SPDX-FileCopyrightText: 2021 ladyada for Adafruit Industries
+# SPDX-License-Identifier: MIT
 
-import time
 import board
-import adafruit_is31fl3741
 from rainbowio import colorwheel
 
-#from adafruit_is31fl3741.issi_evb import ISSI_EVB
 from adafruit_is31fl3741.adafruit_rgbmatrixqt import Adafruit_RGBMatrixQT
 
-i2c = board.I2C()
-
-is31 = Adafruit_RGBMatrixQT(i2c)
+is31 = Adafruit_RGBMatrixQT(board.I2C())
 is31.set_led_scaling(0xFF)
 is31.global_current = 0xFF
-#print("global current is", is31.global_current)
+# print("global current is", is31.global_current)
 is31.enable = True
-#print("Enabled?", is31.enable)
+# print("Enabled?", is31.enable)
 
 wheeloffset = 0
 while True:
 
-    for y in range (9):
-        for x in range (13):
-            is31.pixel(x, y, colorwheel((y*13 + x)*2 + wheeloffset))
+    for y in range(9):
+        for x in range(13):
+            is31.pixel(x, y, colorwheel((y * 13 + x) * 2 + wheeloffset))
     wheeloffset += 1

examples/is31fl3741_simpletest.py

@@ -7,11 +7,11 @@
 
 i2c = board.I2C()
 
-is31 =  adafruit_is31fl3741.IS31FL3741(i2c)
+is31 = adafruit_is31fl3741.IS31FL3741(i2c)
 
-is31.set_led_scaling(0xFF) # turn on LEDs all the way
-is31.global_current = 0xFE # set current to max
-is31.enable = True         # enable!
+is31.set_led_scaling(0xFF)  # turn on LEDs all the way
+is31.global_current = 0xFE  # set current to max
+is31.enable = True  # enable!
 
 # light up every LED, one at a time
 while True: