Skip to content

Added continue system message #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

gamblor21
Copy link
Member

Was looking into MIDI and saw Issue #23 that the Continue message was missing. Added it in. Tested it again Waveform (seeing Start, Stop and now Continue as well when I Play/Pause/Resume).

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this midi_continue because continue is a Python keyword?

@gamblor21
Copy link
Member Author

Is this midi_continue because continue is a Python keyword?

Correct. Sorry forgot to mention that in the PR. That was the best idea I had for a file name, I can change it if there's something that fits better.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Just checking!

@tannewt tannewt merged commit 8842325 into adafruit:master Oct 20, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 24, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#6 from adafruit/fix_pypi

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.8.1 from 1.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#30 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.3.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#26 from gamblor21/add_continue
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#24 from tannewt/run_tests

Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#19 from sayler/issue9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants