make read_data private again

Author: jfurcean

adafruit_nunchuk.py

@@ -54,11 +54,11 @@ class Nunchuk:
     _Buttons = namedtuple("Buttons", ("C", "Z"))
     _Acceleration = namedtuple("Acceleration", ("x", "y", "z"))
 
-    def __init__(self, i2c, address=0x52, i2c_read_delay=0.002, force_read=True):
+    def __init__(self, i2c, address=0x52, i2c_read_delay=0.002):
         self.buffer = bytearray(8)
         self.i2c_device = I2CDevice(i2c, address)
         self._i2c_read_delay = i2c_read_delay
-        self._force_read = force_read
+        self._do_read = True
         time.sleep(_I2C_INIT_DELAY)
         with self.i2c_device as i2c_dev:
             # turn off encrypted data
@@ -70,45 +70,44 @@ def __init__(self, i2c, address=0x52, i2c_read_delay=0.002, force_read=True):
     @property
     def values(self):
         """Return named tuple of all the input values."""
-        self.read_data()
-        temp_force_read = self._force_read
-        self._force_read = False
+        self._read_data()
+        self._do_read = False
         values = self._Values(
             self._Joystick(self.joystick[0], self.joystick[1]),
             self._Buttons(self.button_C, self.button_Z),
             self._Acceleration(
                 self.acceleration[0], self.acceleration[1], self.acceleration[2]
             ),
         )
-        self._force_read = temp_force_read
+        self._do_read = True
         return values
 
     @property
     def joystick(self):
         """Return tuple of current joystick position."""
-        if self._force_read:
-            self.read_data()
+        if self._do_read:
+            self._read_data()
         return self.buffer[0], self.buffer[1]
 
     @property
     def button_C(self):  # pylint: disable=invalid-name
         """Return current pressed state of button C."""
-        if self._force_read:
-            self.read_data()
+        if self._do_read:
+            self._read_data()
         return not bool(self.buffer[5] & 0x02)
 
     @property
     def button_Z(self):  # pylint: disable=invalid-name
         """Return current pressed state of button Z."""
-        if self._force_read:
-            self.read_data()
+        if self._do_read:
+            self._read_data()
         return not bool(self.buffer[5] & 0x01)
 
     @property
     def acceleration(self):
         """Return 3 tuple of accelerometer reading."""
-        if self._force_read:
-            self.read_data()
+        if self._do_read:
+            self._read_data()
         x = (self.buffer[5] & 0xC0) >> 6
         x |= self.buffer[2] << 2
         y = (self.buffer[5] & 0x30) >> 4
@@ -117,7 +116,7 @@ def acceleration(self):
         z |= self.buffer[4] << 2
         return x, y, z
 
-    def read_data(self):
+    def _read_data(self):
         """Reads all of the raw input data from i2c."""
         return self._read_register(b"\x00")
 

examples/nunchuk_accel_mouse.py

@@ -27,7 +27,7 @@
 #    print((0 if nc.button_C else 1, 0 if nc.button_Z else 1))
 
 while True:
-    nc.read_data()
+
     accel = nc.acceleration
     #    print(accel)
     #    x, y = nc.joystick

examples/nunchuk_analog_mouse.py

@@ -27,7 +27,7 @@
 #    print((0 if nc.button_C else 1, 0 if nc.button_Z else 1))
 
 while True:
-    nc.read_data()
+
     x, y = nc.joystick
     # Eliminate spurious reads
     if x == 255 or y == 255:

examples/nunchuk_mouse.py

@@ -12,7 +12,6 @@
 nc = adafruit_nunchuk.Nunchuk(board.I2C())
 
 while True:
-    nc.read_data()
     x, y = nc.joystick
     x = (x - 128) // 2
     y = (128 - y) // 2