Fix pylint & black diagnostics

Author: jepler

examples/ov2640_aio_kaluga1_3.py

@@ -10,24 +10,28 @@
 The audio board must be mounted between the Kaluga and the LCD, it provides the
 I2C pull-ups(!)
 
-This example requires that your WIFI and Adafruit IO credentials be configured in CIRCUITPY/secrets.py, and that you have created a feed called "image" with history disabled.
+This example requires that your WIFI and Adafruit IO credentials be configured
+in CIRCUITPY/secrets.py, and that you have created a feed called "image" with
+history disabled.
 
-The maximum image size is 100kB after base64 encoding, or about 65kB before base64 encoding.  In practice, "SVGA" (800x600) images are typically around 40kB even though the "capture_buffer_size" (theoretical maximum size) is (width*height/5) bytes or 96kB.
+The maximum image size is 100kB after base64 encoding, or about 65kB before
+base64 encoding.  In practice, "SVGA" (800x600) images are typically around
+40kB even though the "capture_buffer_size" (theoretical maximum size) is
+(width*height/5) bytes or 96kB.
 """
 
-import os
-import time
 import binascii
+import ssl
+import time
+from secrets import secrets  # pylint: disable=no-name-in-module
 
 import board
 import busio
 import wifi
 import socketpool
-import ssl
-import adafruit_ov2640
-from secrets import secrets
 import adafruit_minimqtt.adafruit_minimqtt as MQTT
 from adafruit_io.adafruit_io import IO_MQTT
+import adafruit_ov2640
 
 feed_name = "image"
 

examples/ov2640_bmp_sd_kaluga1_3.py

@@ -127,22 +127,22 @@ def exists(filename):
     try:
         os.stat(filename)
         return True
-    except OSError as e:
+    except OSError:
         return False
 
 
 _image_counter = 0
 
 
 def open_next_image(extension="jpg"):
-    global _image_counter
+    global _image_counter  # pylint: disable=global-statement
     while True:
         filename = f"/sd/img{_image_counter:04d}.{extension}"
         _image_counter += 1
         if exists(filename):
             continue
         print("#", filename)
-        return open(filename, "wb")
+        return open(filename, "wb")  # pylint: disable=consider-using-with
 
 
 ### These routines are for writing BMP files in the RGB565 or BGR565 formats.
@@ -197,19 +197,19 @@ def put_padding(length):
     put_dword(144179)  # 2.2 gamma blue
 
 
-def capture_image_bmp(bitmap):
+def capture_image_bmp(the_bitmap):
     with open_next_image("bmp") as f:
-        swapped = np.frombuffer(bitmap, dtype=np.uint16)
+        swapped = np.frombuffer(the_bitmap, dtype=np.uint16)
         swapped.byteswap(inplace=True)
-        write_header(f, bitmap.width, bitmap.height, _bitmask_rgb565)
+        write_header(f, the_bitmap.width, the_bitmap.height, _bitmask_rgb565)
         f.write(swapped)
 
 
 display.auto_refresh = False
 old_record_pressed = True
 
 while True:
-    a_voltage = a.value * a.reference_voltage / 65535
+    a_voltage = a.value * a.reference_voltage / 65535  # pylint: disable=no-member
     cam.capture(bitmap)
     bitmap.dirty()
 

examples/ov2640_directio_kaluga1_3_ili9341.py

@@ -116,22 +116,22 @@ def exists(filename):
     try:
         os.stat(filename)
         return True
-    except OSError as e:
+    except OSError:
         return False
 
 
 _image_counter = 0
 
 
 def open_next_image():
-    global _image_counter
+    global _image_counter  # pylint: disable=global-statement
     while True:
         filename = f"/sd/img{_image_counter:04d}.jpg"
         _image_counter += 1
         if exists(filename):
             continue
         print("#", filename)
-        return open(filename, "wb")
+        return open(filename, "wb")  # pylint: disable=consider-using-with
 
 
 def capture_image():
@@ -160,7 +160,7 @@ def main():
     display_bus.send(43, struct.pack(">hh", 0, 239))
     t0 = time.monotonic_ns()
     while True:
-        a_voltage = a.value * a.reference_voltage / 65535
+        a_voltage = a.value * a.reference_voltage / 65535  # pylint: disable=no-member
         record_pressed = abs(a_voltage - V_RECORD) < 0.05
         if record_pressed:
             capture_image()

examples/ov2640_jpeg_kaluga1_3.py

@@ -50,6 +50,7 @@
 except OSError as e:
     print(e)
     print(
-        "A 'read-only filesystem' error occurs if you did not correctly install\nov2640_jpeg_kaluga1_3_boot.py as CIRCUITPY/boot.py and reset the board"
+        "A 'read-only filesystem' error occurs if you did not correctly install"
+        "\nov2640_jpeg_kaluga1_3_boot.py as CIRCUITPY/boot.py and reset the board"
     )
 print("Wrote to CIRCUITPY/jpeg.jpg")

examples/ov2640_jpeg_kaluga1_3_boot.py

@@ -17,7 +17,7 @@
 V_RECORD = 2.41
 
 a = analogio.AnalogIn(board.IO6)
-a_voltage = a.value * a.reference_voltage / 65535
+a_voltage = a.value * a.reference_voltage / 65535  # pylint: disable=no-member
 if abs(a_voltage - V_MODE) > 0.05:  # If mode is NOT pressed...
     print("storage writable by CircuitPython")
     storage.remount("/", readonly=False)

examples/ov2640_jpeg_sd_kaluga1_3.py

@@ -95,22 +95,22 @@ def exists(filename):
     try:
         os.stat(filename)
         return True
-    except OSError as e:
+    except OSError:
         return False
 
 
 _image_counter = 0
 
 
 def open_next_image():
-    global _image_counter
+    global _image_counter  # pylint: disable=global-statement
     while True:
         filename = f"/sd/img{_image_counter:04d}.jpg"
         _image_counter += 1
         if exists(filename):
             continue
         print("#", filename)
-        return open(filename, "wb")
+        return open(filename, "wb")  # pylint: disable=consider-using-with
 
 
 def capture_image():
@@ -131,16 +131,12 @@ def capture_image():
         cam.colorspace = old_colorspace
 
 
-def main():
-    display.auto_refresh = False
-    while True:
-        a_voltage = a.value * a.reference_voltage / 65535
-        record_pressed = abs(a_voltage - V_RECORD) < 0.05
-        if record_pressed:
-            capture_image()
-        cam.capture(bitmap)
-        bitmap.dirty()
-        display.refresh(minimum_frames_per_second=0)
-
-
-main()
+display.auto_refresh = False
+while True:
+    a_voltage = a.value * a.reference_voltage / 65535  # pylint: disable=no-member
+    record_pressed = abs(a_voltage - V_RECORD) < 0.05
+    if record_pressed:
+        capture_image()
+    cam.capture(bitmap)
+    bitmap.dirty()
+    display.refresh(minimum_frames_per_second=0)

examples/ov2640_simpletest.py

@@ -23,7 +23,6 @@
 import sys
 import time
 
-import digitalio
 import busio
 import board