Skip to content

Commit 2a98a69

Browse files
committed
changes per reviewer suggestions
1 parent 7421e57 commit 2a98a69

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

adafruit_pcf8591/analog_in.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,19 @@
2929

3030
try:
3131
import typing # pylint: disable=unused-import
32+
from adafruit_pcf8591.pcf8591.PCF8591 import PCF8591
3233
except ImportError:
3334
pass
3435

3536

3637
class AnalogIn:
3738
"""AnalogIn Mock Implementation for ADC Reads."""
3839

39-
def __init__(self, pcf: "PCF8591", pin: int) -> None:
40+
def __init__(self, pcf: PCF8591, pin: int) -> None:
4041
"""AnalogIn
4142
42-
:param ads: The PCF8591 object.
43-
:param ~digitalio.DigitalInOut pin: Required ADC channel pin.
43+
:param pcf: The PCF8591 object.
44+
:param int pin: Required ADC channel pin.
4445
4546
"""
4647
self._pcf = pcf

adafruit_pcf8591/analog_out.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,19 @@
2828
"""
2929
try:
3030
import typing # pylint: disable=unused-import
31+
from adafruit_pcf8591.pcf8591.PCF8591 import PCF8591
3132
except ImportError:
3233
pass
3334

3435

3536
class AnalogOut:
3637
"""AnalogIn Mock Implementation for ADC Reads."""
3738

38-
def __init__(self, pcf: "PCF8591", dac_pin: int = 0) -> None:
39+
def __init__(self, pcf: PCF8591, dac_pin: int = 0) -> None:
3940
"""AnalogIn
4041
4142
:param pcf: The pcf object.
42-
:param ~digitalio.DigitalInOut DAC pin: Required pin must be P4
43+
:param int pin: Required pin must be A0
4344
4445
"""
4546
self._pcf = pcf

adafruit_pcf8591/pcf8591.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def _half_read(self, channel: Literal[0, 1, 2, 3]) -> None:
100100
def read(self, channel: Literal[0, 1, 2, 3]) -> None:
101101
"""Read an analog value from one of the four ADC inputs
102102
103-
param: :channel The single-ended ADC channel to read from, 0 thru 3
103+
param: int channel The single-ended ADC channel to read from, 0 thru 3
104104
"""
105105
if channel < 0 or channel > 3:
106106
raise ValueError("channel must be from 0-3")

0 commit comments

Comments
 (0)