Merge pull request #30 from FoamyGuy/master

Change get_firmware_version() function to a property

Author: kattni

adafruit_pn532/adafruit_pn532.py

@@ -196,11 +196,11 @@ def __init__(self, *, debug=False, reset=None):
 
         try:
             self._wakeup()
-            self.get_firmware_version() # first time often fails, try 2ce
+            _ = self.firmware_version  # first time often fails, try 2ce
             return
         except (BusyError, RuntimeError):
             pass
-        self.get_firmware_version()
+        _ = self.firmware_version
 
     def _read_data(self, count):
         # Read raw data from device, not including status bytes:
@@ -317,7 +317,8 @@ def call_function(self, command, response_length=0, params=[], timeout=1): # pyl
         # Return response data.
         return response[2:]
 
-    def get_firmware_version(self):
+    @property
+    def firmware_version(self):
         """Call PN532 GetFirmwareVersion function and return a tuple with the IC,
         Ver, Rev, and Support values.
         """

examples/pn532_readwrite_mifare.py

@@ -62,7 +62,7 @@
 #uart = busio.UART(board.TX, board.RX, baudrate=115200, timeout=100)
 #pn532 = PN532_UART(uart, debug=False)
 
-ic, ver, rev, support = pn532.get_firmware_version()
+ic, ver, rev, support = pn532.firmware_version
 print('Found PN532 with firmware version: {0}.{1}'.format(ver, rev))
 
 # Configure PN532 to communicate with MiFare cards

examples/pn532_readwrite_ntag2xx.py

@@ -58,7 +58,7 @@
 #uart = busio.UART(board.TX, board.RX, baudrate=115200, timeout=100)
 #pn532 = PN532_UART(uart, debug=False)
 
-ic, ver, rev, support = pn532.get_firmware_version()
+ic, ver, rev, support = pn532.firmware_version
 print('Found PN532 with firmware version: {0}.{1}'.format(ver, rev))
 
 # Configure PN532 to communicate with MiFare cards

examples/pn532_simpletest.py

@@ -38,7 +38,7 @@
 #uart = busio.UART(board.TX, board.RX, baudrate=115200, timeout=100)
 #pn532 = PN532_UART(uart, debug=False)
 
-ic, ver, rev, support = pn532.get_firmware_version()
+ic, ver, rev, support = pn532.firmware_version
 print('Found PN532 with firmware version: {0}.{1}'.format(ver, rev))
 
 # Configure PN532 to communicate with MiFare cards