Skip to content

Commit 740dba4

Browse files
committed
fixing pylint
1 parent 54058dc commit 740dba4

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

adafruit_sgp40.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
3030
"""
3131
from time import sleep
32-
from struct import unpack_from, pack_into
33-
from micropython import const
32+
from struct import unpack_from
3433
import adafruit_bus_device.i2c_device as i2c_device
3534

3635
__version__ = "0.0.0-auto.0"
@@ -56,15 +55,15 @@ def initialize(self):
5655
# check serial number
5756
self._command_buffer[0] = 0x36
5857
self._command_buffer[1] = 0x82
59-
serialnumber = self.readWordFromCommand(3)
58+
serialnumber = self._read_word_from_command(3)
6059

6160
if serialnumber[0] != 0x0000:
6261
raise RuntimeError("Serial number does not match")
6362

6463
# Check feature set
6564
self._command_buffer[0] = 0x20
6665
self._command_buffer[1] = 0x2F
67-
featureset = self.readWordFromCommand()
66+
featureset = self._read_word_from_command()
6867
if featureset[0] != 0x3220:
6968

7069
raise RuntimeError("Feature set does not match: %s" % hex(featureset[0]))
@@ -74,7 +73,7 @@ def initialize(self):
7473
# Self Test
7574
self._command_buffer[0] = 0x28
7675
self._command_buffer[1] = 0x0E
77-
self_test = self.readWordFromCommand(delay_ms=250)
76+
self_test = self._read_word_from_command(delay_ms=250)
7877
if self_test[0] != 0xD400:
7978
raise RuntimeError("Self test failed")
8079
self._reset()
@@ -85,7 +84,7 @@ def _reset(self):
8584
self._command_buffer[0] = 0x00
8685
self._command_buffer[1] = 0x06
8786
try:
88-
self.readWordFromCommand(delay_ms=50)
87+
self._read_word_from_command(delay_ms=50)
8988
except OSError:
9089
# print("\tGot expected OSError from reset")
9190
pass
@@ -96,28 +95,30 @@ def raw(self):
9695
"""The raw gas value"""
9796
# recycle a single buffer
9897
self._command_buffer = bytearray(_READ_CMD)
99-
read_value = self.readWordFromCommand(delay_ms=250)
98+
read_value = self._read_word_from_command(delay_ms=250)
10099
self._command_buffer = bytearray(2)
101100
return read_value[0]
102101

103-
def readWordFromCommand(
102+
def _read_word_from_command(
104103
self,
105104
delay_ms=10,
106105
readlen=1,
107106
):
108-
"""readWordFromCommand - send a given command code and read the result back
107+
"""_read_word_from_command - send a given command code and read the result back
109108
110109
Args:
111-
delay_ms (int, optional): The delay between write and read, in milliseconds. Defaults to 10ms
110+
delay_ms (int, optional): The delay between write and read, in milliseconds.
111+
Defaults to 10ms
112112
readlen (int, optional): The number of bytes to read. Defaults to 1.
113113
"""
114+
# TODO: Take 2-byte command as int (0x280E, 0x0006) and packinto command buffer
114115

115116
with self.i2c_device as i2c:
116117
i2c.write(self._command_buffer)
117118

118119
sleep(round(delay_ms * 0.001, 3))
119120

120-
if readlen == None:
121+
if readlen is None:
121122
return None
122123
readdata_buffer = []
123124

0 commit comments

Comments
 (0)