Skip to content

additional examples #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2023
Merged

additional examples #4

merged 2 commits into from
Mar 1, 2023

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Mar 1, 2023

Two new examples:

  • Colored stripes that show each of the possible 7 colors
  • Border and colored rect fill with text layered on top. This mimics a common simpletest from many displayio driver repos.

jposada202020
jposada202020 reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did not test. However, the script follows the same logic as for the tricolour display. Would be good to add the reference to the examples.rst file to show them in RTD. Thanks.

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Mar 1, 2023

Thank you for taking a look @jposada202020!

New commit adds the examples to rst file.

@jposada202020
Copy link
Contributor

Thank you :)

@jposada202020 jposada202020 merged commit 2817abd into adafruit:main Mar 1, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 2, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@2415fa6)
e66680b 
Updating https://github.com/adafruit/Adafruit_CircuitPython_SPD1656 to 0.8.2 from 0.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SPD1656#4 from FoamyGuy/more_examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jposada202020 jposada202020 jposada202020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FoamyGuy @jposada202020