Skip to content

Don't import Micropython framebuf in Circuitpython #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Don't import Micropython framebuf in Circuitpython #84

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ae8b59
don't import Micropython framebuf in Circuitpython
RetiredWizard Nov 4, 2023
584d849
blinka has an implementation.name of 'cpython'
RetiredWizard Nov 4, 2023
e37011e
Test if running on Blinka, not Micropython
RetiredWizard Nov 4, 2023
fb74917
Import based on all three run environments
RetiredWizard Nov 4, 2023
b45cd45
This version should make CI happy
RetiredWizard Nov 4, 2023
fd95412
mp framebuf is native C, cpython can't load it
RetiredWizard Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions adafruit_ssd1306.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,16 @@

import time

from sys import implementation
from micropython import const
from adafruit_bus_device import i2c_device, spi_device

try:
if implementation.name.upper() == "MICROPYTHON":
# MicroPython framebuf import
import framebuf

_FRAMEBUF_FORMAT = framebuf.MONO_VLSB
except ImportError:
else:
# CircuitPython framebuf import
import adafruit_framebuf as framebuf

Expand Down