Skip to content

Add quotes example for magtag #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 14, 2020
Merged

Add quotes example for magtag #1302

merged 8 commits into from
Nov 14, 2020

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Nov 14, 2020

two text areas with different fonts with simple text wrapping.

@ladyada ladyada requested a review from jedgarpark November 14, 2020 00:43
jepler
jepler approved these changes Nov 14, 2020
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts I had while reviewing

  • quote_transform() appears to be unused
  • the resolution of time.monotonic() vs 60 seconds is fine for any plausible scenario

@ladyada
Copy link
Member Author

ladyada commented Nov 14, 2020

removed the unused transform (was testin stuff)

@jepler jepler self-requested a review November 14, 2020 18:55
@jepler jepler merged commit 4c4afee into adafruit:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

@jedgarpark jedgarpark Awaiting requested review from jedgarpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @jepler