Skip to content

Update lightbox for CircuitPython 5.0.0-beta.0 BLE API #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 4, 2019
Merged

Update lightbox for CircuitPython 5.0.0-beta.0 BLE API #944

merged 5 commits into from
Dec 4, 2019

Conversation

dhalbert
Copy link
Contributor

No description provided.

@dhalbert dhalbert requested a review from TheKitty November 25, 2019 01:57
@dhalbert dhalbert requested a review from jerryneedell December 4, 2019 14:50
@dhalbert
Copy link
Contributor Author

dhalbert commented Dec 4, 2019

@jerryneedell Would you have time to test this? It's very simple. Thank you.

@jerryneedell
Copy link
Collaborator

Tested on feather_nRF52840 -- works well!

jerryneedell
jerryneedell approved these changes Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on feather_nRF52840 -- no problems.

@dhalbert dhalbert merged commit 7e26af0 into adafruit:master Dec 4, 2019
@dhalbert dhalbert deleted the cpy5beta0-lightbox branch December 4, 2019 16:30
@dhalbert dhalbert removed the request for review from TheKitty December 4, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @jerryneedell