Skip to content

Commit d2c5538

Browse files
authored
Merge pull request #614 from adafruit/followup-pr609
follow up to PR-609
2 parents 2cbb155 + 97d7ce7 commit d2c5538

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

.github/workflows/githubci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,8 @@ jobs:
5454
ln -s $GITHUB_WORKSPACE $HOME/$BSP_PATH/$BSP_VERSION
5555
5656
# Install library dependency
57-
arduino-cli lib install "Adafruit AHRS" "Adafruit APDS9960 Library" "Adafruit Arcada Library" "Adafruit BMP280 Library" "Adafruit Circuit Playground" "Adafruit EPD" "Adafruit GFX Library" "Adafruit HX8357 Library" "Adafruit ILI9341" "Adafruit LIS3MDL" "Adafruit LSM6DS" "Adafruit NeoPixel" "Adafruit NeoMatrix" "Adafruit Sensor Calibration" "Adafruit SHT31 Library" "Adafruit SSD1306" "Adafruit ST7735 and ST7789 Library" "SdFat - Adafruit Fork"
57+
arduino-cli lib install "Adafruit AHRS" "Adafruit APDS9960 Library" "Adafruit Arcada Library" "Adafruit BMP280 Library" "Adafruit Circuit Playground" "Adafruit EPD" "Adafruit GFX Library" "Adafruit HX8357 Library" "Adafruit ILI9341" "Adafruit LIS3MDL" "Adafruit LSM6DS" "Adafruit NeoPixel" "Adafruit NeoMatrix" "Adafruit Sensor Calibration" "Adafruit SHT31 Library" "Adafruit SSD1306" "Adafruit ST7735 and ST7789 Library" "MIDI Library" "SdFat - Adafruit Fork"
5858
59-
# TODO update to support MIDI version 5 later on
60-
arduino-cli lib install "MIDI Library"@4.3.1
61-
6259
# TODO use firmata master to prevent build error with gcc v9 (should be remove after 2.5.9 is released)
6360
# https://github.com/firmata/arduino/pull/438
6461
git clone --depth 1 https://github.com/firmata/arduino.git $HOME/Arduino/libraries/firmata

libraries/Bluefruit52Lib/src/services/BLEMidi.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ err_t BLEMidi::begin(void)
161161
return ERROR_NONE;
162162
}
163163

164-
bool BLEMidi::beginTransmission(MIDI_NAMESPACE::MidiType type)
164+
bool BLEMidi::beginTransmission(uint8_t type)
165165
{
166166
return true;
167167
};

libraries/Bluefruit52Lib/src/services/BLEMidi.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535
#ifndef BLEMIDI_H_
3636
#define BLEMIDI_H_
3737

38-
#include <MIDI.h>
39-
4038
#include "bluefruit_common.h"
4139
#include "utility/adafruit_fifo.h"
4240

@@ -76,7 +74,7 @@ class BLEMidi: public BLEService, public Stream
7674
void setWriteCallback(midi_write_cb_t fp);
7775
void autoMIDIread(void* midi_obj);
7876

79-
bool beginTransmission(MIDI_NAMESPACE::MidiType type);
77+
bool beginTransmission(uint8_t type);
8078
void endTransmission();
8179

8280
// Stream API for MIDI Interface

0 commit comments

Comments
 (0)