Skip to content

Add CircuitPython_bteve as bteve #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2021
Merged

Add CircuitPython_bteve as bteve #58

merged 3 commits into from
Mar 3, 2021

Conversation

jamesbowman
Copy link
Contributor

This adds the rest of the EVE support stack.

tannewt
tannewt requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the diff should also show the directory itself. Did you add it with git submodule add?

@tannewt
Copy link
Member

tannewt commented Mar 2, 2021

I think you'll need to switch .gitmodules to https to fix the permission error and also tag a release in your repo (otherwise the auto-update code doesn't know what to do.)

@jamesbowman
Copy link
Contributor Author

Oops, url fixed. And I tagged repo CircuitPython_bteve with 0.1.2

tannewt
tannewt approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@tannewt tannewt merged commit 6f2c2f0 into adafruit:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbowman @tannewt