Skip to content

Commit 21097ea

Browse files
committed
clean up font awesome icons with aria-hidden and titles as necessary
1 parent d9e42fd commit 21097ea

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

_includes/download/blinka.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ <h3>Adafruit Blinka Installation</h3>
1212
so much because they all happen underneath the adafruit_blinka layer.
1313
</p>
1414
<div>
15-
<a class="download-button" href="{{ page.download_instructions }}">INSTALLATION INSTRUCTIONS<i class="fas fa-arrow-circle-right"></i></a>
15+
<a class="download-button" href="{{ page.download_instructions }}">INSTALLATION INSTRUCTIONS<i class="fas fa-arrow-circle-right" aria-hidden="true"></i></a>
1616
<div class="clear"></div>
1717
</div>
1818
</div>

_includes/download/board.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ <h3>CircuitPython {{ version.version }}</h3>
5555
</label>
5656
<div class="download-buttons">
5757
{% for file in version.files['en_US'] %}
58-
<a class="download-button {% if version.stable %}stable{% else %}unstable{% endif %} {{ file | slice: -3, 3 }}" href="{{ file }}">DOWNLOAD {{ file | slice: -4, 4 | upcase }} NOW <i class="fas fa-download"></i></a>
58+
<a class="download-button {% if version.stable %}stable{% else %}unstable{% endif %} {{ file | slice: -3, 3 }}" href="{{ file }}">DOWNLOAD {{ file | slice: -4, 4 | upcase }} NOW <i class="fas fa-download" aria-hidden="true"></i></a>
5959
{% endfor %}
6060
</div>
6161
</div>
@@ -70,7 +70,7 @@ <h3>Absolute Newest</h3>
7070
the absolute latest and are feeling risky.
7171
</p>
7272
<div>
73-
<a class="download-button-unrecommended" href="https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin/{{ page.board_id }}/">BROWSE S3<i class="fas fa-arrow-circle-right"></i></a>
73+
<a class="download-button-unrecommended" href="https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin/{{ page.board_id }}/">BROWSE S3<i class="fas fa-arrow-circle-right" aria-hidden="true"></i></a>
7474
<div class="clear"></div>
7575
</div>
7676
</div>
@@ -81,7 +81,7 @@ <h3>Past Releases</h3>
8181
the latest stable otherwise.
8282
</p>
8383
<div>
84-
<a class="download-button-unrecommended" href="https://github.com/adafruit/circuitpython/releases">BROWSE GITHUB<i class="fab fa-github"></i></a>
84+
<a class="download-button-unrecommended" href="https://github.com/adafruit/circuitpython/releases">BROWSE GITHUB<i class="fab fa-github" aria-hidden="true"></i></a>
8585
<div class="clear"></div>
8686
</div>
8787
</div>

assets/javascript/downloads.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ function shouldDisplayDownload(download, displayedManufacturers, displayedFeatur
263263
}
264264

265265
function appendFilterTag(type, name) {
266-
var tagHtml = "<span class='tag'><i class='fas fa-times tag-remove' ";
266+
var tagHtml = "<span class='tag'><i class='fas fa-times tag-remove' title='Remove Filtered Option'";
267267
tagHtml += "data-type='" + type + "' ";
268268
tagHtml += "data-name='" + name + "'></i>";
269269
tagHtml += name + "</span>";

blinka.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ <h1>Blinka</h1>
1313
</label>
1414
</div>
1515
<div class="downloads-filter">
16-
<button class="filter" title="Filter Boards"><i class="fas fa-sliders-h"></i></button>
16+
<button class="filter" title="Filter Boards"><i class="fas fa-sliders-h" aria-hidden="true"></i></button>
1717
</div>
1818
<div class="downloads-filter-tags">
1919
</div>
2020
</div>
2121
<div class="downloads-filter-content">
2222
<div class="filter-buttons">
23-
<button class="save-changes" title="Close and Save Changes"><i class="fas fa-times"></i></button>
23+
<button class="save-changes" title="Close and Save Changes"><i class="fas fa-times" aria-hidden="true"></i></button>
2424
</div>
2525
<div>
2626
<div class="manufacturers">

downloads.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ <h1>Downloads</h1>
1313
</label>
1414
</div>
1515
<div class="downloads-filter">
16-
<button class="filter" title="Filter Boards"><i class="fas fa-sliders-h"></i></button>
16+
<button class="filter" title="Filter Boards"><i class="fas fa-sliders-h" aria-hidden="true"></i></button>
1717
</div>
1818
<div class="downloads-filter-tags">
1919
</div>
2020
</div>
2121
<div class="downloads-filter-content">
2222
<div class="filter-buttons">
23-
<button class="save-changes" title="Close and Save Changes"><i class="fas fa-times"></i></button>
23+
<button class="save-changes" title="Close and Save Changes"><i class="fas fa-times" aria-hidden="true"></i></button>
2424
</div>
2525
<div>
2626
<div class="manufacturers">

0 commit comments

Comments
 (0)