Skip to content

Commit ae75105

Browse files
committed
fix filter logic & add @FoamyGuy's formatting
1 parent 5f4aed5 commit ae75105

File tree

2 files changed

+34
-22
lines changed

2 files changed

+34
-22
lines changed

assets/javascript/downloads.js

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -387,29 +387,39 @@ function shouldDisplayDownload(download, displayedManufacturers, displayedMcufam
387387

388388
if (shouldFilterManufacturers) {
389389
if (displayedManufacturers.includes(id)) {
390-
if (shouldFilterFeatures) {
391-
if (displayedFeatures.includes(id)) {
392-
shouldDisplay = true;
393-
}
390+
if (shouldFilterMcufamilies) {
391+
if (displayedMcufamilies.includes(id)) {
392+
if (shouldFilterFeatures) {
393+
if (displayedFeatures.includes(id)) {
394+
shouldDisplay = true;
395+
}
396+
} else {
397+
shouldDisplay = true;
398+
}
399+
}
400+
} else if (shouldFilterFeatures) {
401+
if (displayedFeatures.includes(id)) {
402+
shouldDisplay = true;
403+
}
394404
} else {
395405
shouldDisplay = true;
396406
}
397407
}
398-
} else if (shouldFilterFeatures && displayedFeatures.includes(id)) {
399-
shouldDisplay = true;
400-
}
401-
402-
if (shouldFilterMcufamilies) {
408+
} else if (shouldFilterMcufamilies) {
403409
if (displayedMcufamilies.includes(id)) {
404410
if (shouldFilterFeatures) {
405411
if (displayedFeatures.includes(id)) {
406412
shouldDisplay = true;
407413
}
408414
} else {
409-
shouldDisplay = true;
415+
shouldDisplay = true;
410416
}
411417
}
412-
} else if (shouldFilterFeatures && displayedFeatures.includes(id)) {
418+
} else if (shouldFilterFeatures) {
419+
if (displayedFeatures.includes(id)) {
420+
shouldDisplay = true;
421+
}
422+
} else {
413423
shouldDisplay = true;
414424
}
415425

downloads.html

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,19 @@ <h1>Downloads</h1>
3030
<ul class="content"></ul>
3131
</fieldset>
3232
</div>
33-
<div class="mcufamilies">
34-
<fieldset>
35-
<legend>Processor family</legend>
36-
<ul class="content"></ul>
37-
</fieldset>
38-
</div>
39-
<div class="features">
40-
<fieldset>
41-
<legend>Features</legend>
42-
<ul class="content"></ul>
43-
</fieldset>
33+
<div>
34+
<div class="features">
35+
<fieldset>
36+
<legend>Features</legend>
37+
<ul class="content"></ul>
38+
</fieldset>
39+
</div>
40+
<div class="mcufamilies">
41+
<fieldset>
42+
<legend>Processor family</legend>
43+
<ul class="content"></ul>
44+
</fieldset>
45+
</div>
4446
</div>
4547
<div class="sort-by">
4648
<fieldset>

0 commit comments

Comments
 (0)