Skip to content

Added Date Sorting for Blinka boards #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Added Date Sorting for Blinka boards #439

merged 3 commits into from
Apr 1, 2020

Conversation

makermelissa
Copy link
Collaborator

@makermelissa makermelissa commented Mar 31, 2020

Added date Sorting for Blinka boards. Fixes #299. Went through and added "data_added" using initial GitHub PR dates. Cleaned up some console.log statements. This also fixes the PocketBeagle Name. Also fixes a Javascript error I found when loading Blinka page on live site:

Uncaught TypeError: Cannot read property 'length' of null
    at handlePageLoad (downloads.js:76)
    at HTMLDocument.<anonymous> (downloads.js:26)

I tested this locally and it seems to work very well.

@makermelissa makermelissa requested a review from a team March 31, 2020 21:40
This was referenced Apr 1, 2020
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks again.

@tannewt tannewt merged commit b23738c into adafruit:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Sort by Date Added
2 participants