Skip to content

Add MagTag 2.9 plus update ESP32S2 Metro #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

Add MagTag 2.9 plus update ESP32S2 Metro #579

merged 1 commit into from
Nov 10, 2020
+48 −3

Conversation

makermelissa
Copy link
Collaborator

This is one I'm glad I tested before submitting. The quote in the 2.9" was a curve ball.

@makermelissa makermelissa requested a review from a team November 10, 2020 18:06
FoamyGuy
FoamyGuy approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this locally and checked served pages. Both changes look good to me. I see MagTag in the list of downloads now. and the Metro ESP32 S2 has a new image and no longer says coming soon.

@makermelissa makermelissa merged commit c02c103 into adafruit:master Nov 10, 2020
@makermelissa
Copy link
Collaborator Author

Thanks for reviewing @FoamyGuy

@ladyada
Copy link
Member

ladyada commented Nov 10, 2020

@kattni check in a few mins!

@dglaude dglaude mentioned this pull request Nov 10, 2020
Closed
@kattni
Copy link
Contributor

kattni commented Nov 24, 2020

I somehow missed this. Verified both work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@makermelissa @ladyada @kattni @FoamyGuy