Skip to content

Added pages for Pimoroni's PicoLipo boards #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2021

Conversation

ZodiusInfuser
Copy link
Contributor

This covers the 16mb and 4mb versions of the PicoLipo board. The former should be launching this week, so if we would get this merged soon, that would be greatly appreciated!

@ladyada ladyada requested a review from makermelissa May 13, 2021 14:07
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting. Could you please resize the photos according to this guide: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images? Otherwise it looks good.

@ZodiusInfuser
Copy link
Contributor Author

ZodiusInfuser commented May 13, 2021

Hi. Could you elaborate on what's wrong? We've prepared pictures exactly as described on the github page, and ran them through the recommended webpage to compress them.

Provide 3 images. An original high-quality image. A smaller image (300 px width), and a larger image (700 px width) in each respective directory (assets/images/boards/{small large original}) and process them in something like https://squoosh.app/ to reduce file size.

This is the exact same process we did for our previous boards without issue.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, fair enough. I just checked the other images (same dimensions) and they look fine. Maybe the image sizing is a bit more resilient than I thought. :)

@makermelissa makermelissa merged commit 4ae5e2d into adafruit:master May 13, 2021
@ZodiusInfuser
Copy link
Contributor Author

Thanks @makermelissa! I'm curious now what the issue was that made you flag this. That guide does mention different dimensions to what this repo says, so perhaps ones needs to be updated?

@makermelissa
Copy link
Collaborator

Oh, it's recommended to have the images at a 13:10 ratio (like the other images on the site), but yours are 4:3. It looks fine either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants