Skip to content

update libraries page and header links #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

update libraries page and header links #741

merged 1 commit into from
Aug 19, 2021

Conversation

dhalbert
Copy link
Collaborator

I did some rewriting on the libraries page:

  • Added link to readthedocs for all libraries.
  • Reworked the .mpy explanation and other text.
  • Added link to Libraries page in Welcome guide in two places
  • Mentioned CircUp.
  • Mentioned and linked to the Community Bundle. This could be expanded later.
  • Redid headings a bit

I also revamped the top links a bit, renaming "API to "Documentation" "Help" to "Forums", and labelling the Discord and RSS links more explicitly.
The mobile header was also updated.
OLD:
image
NEW:
image

Fixes #53
Fixes #526
Fixes #633

I tested the HTML and the looks locally.

kattni
kattni reviewed Aug 19, 2021
View reviewed changes
kattni
kattni approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalbert This is an excellent update. I'll ping Justin directly to take a look, and then get it merged. Thank you!

makermelissa
makermelissa approved these changes Aug 19, 2021
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kattni kattni merged commit f5bf928 into adafruit:master Aug 19, 2021
@dhalbert dhalbert deleted the lib-documentation-improvements branch August 19, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwcooper jwcooper jwcooper approved these changes

@makermelissa makermelissa makermelissa approved these changes

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention community bundle Add a link to the ReadTheDocs on the homepage Have mpy-cross Available For Download
4 participants
@dhalbert @jwcooper @makermelissa @kattni