Skip to content

Adding seperate boards for PyCubed v04 and v05 #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 24, 2021

Conversation

maholli
Copy link
Contributor

@maholli maholli commented Sep 13, 2021

This PR aligns circuitpython-org resources to pending changes on main circuitpython.

❗ Important

Please don't merge this RP until adafruit/circuitpython#5302 is approved and merged. Thanks! πŸ™‚

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until the CP PR is merged in.

@maholli maholli requested a review from tannewt September 20, 2021 22:35
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the image file names of the existing board. That way they should all match board ID. It's ok to change title and name.

@maholli
Copy link
Contributor Author

maholli commented Sep 21, 2021

Please don't change the image file names of the existing board. That way they should all match board ID. It's ok to change title and name.

Fixed πŸ˜„

@tannewt
Copy link
Member

tannewt commented Sep 22, 2021

You need to change the actual files back too.

@maholli
Copy link
Contributor Author

maholli commented Sep 22, 2021

You need to change the actual files back too.

Darn! VERY sorry for the oversight & making you catch that. Incorrectly assumed the build check would catch it.

@tannewt tannewt merged commit 096cbe3 into adafruit:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants