Merge pull request #5955 from prplz/is31fl3741

dhalbert · web-flow · commit 0b26dba44d1d · 2022-02-01T12:55:31.000-05:00
Only enable is31fl3741 for led glasses board
diff --git a/ports/nrf/boards/adafruit_led_glasses_nrf52840/mpconfigboard.mk b/ports/nrf/boards/adafruit_led_glasses_nrf52840/mpconfigboard.mk
@@ -5,6 +5,7 @@ USB_MANUFACTURER = "Adafruit Industries LLC"
 
 MCU_CHIP = nrf52840
 
-
 QSPI_FLASH_FILESYSTEM = 1
 EXTERNAL_FLASH_DEVICES = "GD25Q16C"
+
+CIRCUITPY_IS31FL3741 = 1
diff --git a/ports/nrf/boards/bluemicro833/mpconfigboard.mk b/ports/nrf/boards/bluemicro833/mpconfigboard.mk
@@ -24,7 +24,6 @@ CIRCUITPY_DISPLAYIO = 0
 CIRCUITPY_FRAMEBUFFERIO = 0
 CIRCUITPY_FREQUENCYIO = 0
 CIRCUITPY_I2CPERIPHERAL = 0
-CIRCUITPY_IS31FL3741 = 0
 CIRCUITPY_JSON = 0
 CIRCUITPY_KEYPAD = 1
 CIRCUITPY_MSGPACK = 0
diff --git a/ports/nrf/boards/microbit_v2/mpconfigboard.mk b/ports/nrf/boards/microbit_v2/mpconfigboard.mk
@@ -12,7 +12,6 @@ CIRCUITPY_BUILTINS_POW3=0
 CIRCUITPY_BUSDEVICE = 0
 CIRCUITPY_COUNTIO = 0
 CIRCUITPY_DISPLAYIO = 0
-CIRCUITPY_IS31FL3741 = 0
 CIRCUITPY_FRAMEBUFFERIO = 0
 CIRCUITPY_FREQUENCYIO = 0
 CIRCUITPY_I2CPERIPHERAL = 0
diff --git a/ports/nrf/boards/pca10100/mpconfigboard.mk b/ports/nrf/boards/pca10100/mpconfigboard.mk
@@ -19,7 +19,6 @@ CIRCUITPY_DISPLAYIO = 0
 CIRCUITPY_FRAMEBUFFERIO = 0
 CIRCUITPY_FREQUENCYIO = 0
 CIRCUITPY_I2CPERIPHERAL = 0
-CIRCUITPY_IS31FL3741 = 0
 CIRCUITPY_JSON = 0
 CIRCUITPY_KEYPAD = 0
 CIRCUITPY_MSGPACK = 0
diff --git a/ports/nrf/boards/simmel/mpconfigboard.mk b/ports/nrf/boards/simmel/mpconfigboard.mk
@@ -22,7 +22,6 @@ CIRCUITPY_DISPLAYIO = 0
 CIRCUITPY_ERRNO = 0
 CIRCUITPY_FRAMEBUFFERIO = 0
 CIRCUITPY_GETPASS = 0
-CIRCUITPY_IS31FL3741 = 0
 CIRCUITPY_KEYPAD = 0
 CIRCUITPY_MSGPACK = 0
 CIRCUITPY_NEOPIXEL_WRITE = 0
diff --git a/ports/nrf/mpconfigport.mk b/ports/nrf/mpconfigport.mk
@@ -27,8 +27,6 @@ CIRCUITPY_BLEIO ?= 1
 # No I2CPeripheral implementation
 CIRCUITPY_I2CPERIPHERAL = 0
 
-CIRCUITPY_IS31FL3741 ?= 1
-
 CIRCUITPY_RTC ?= 1
 
 # frequencyio not yet implemented
diff --git a/shared-module/is31fl3741/IS31FL3741.c b/shared-module/is31fl3741/IS31FL3741.c
@@ -115,7 +115,7 @@ void common_hal_is31fl3741_IS31FL3741_reconstruct(is31fl3741_IS31FL3741_obj_t *s
     is31fl3741_set_current(self->i2c, self->device_address, 0xFF);
 
     // set scale (brightness) to max for all LEDs
-    for (int i; i < 351; i++) {
+    for (int i = 0; i < 351; i++) {
         is31fl3741_set_led(self->i2c, self->device_address, i, 0xFF, 2);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ void common_hal_is31fl3741_IS31FL3741_reconstruct(is31fl3741_IS31FL3741_obj_t *s`
`115`	`115`	`is31fl3741_set_current(self->i2c, self->device_address, 0xFF);`
`116`	`116`
`117`	`117`	`// set scale (brightness) to max for all LEDs`
`118`		`- for (int i; i < 351; i++) {`
	`118`	`+ for (int i = 0; i < 351; i++) {`
`119`	`119`	`is31fl3741_set_led(self->i2c, self->device_address, i, 0xFF, 2);`
`120`	`120`	`}`
`121`	`121`