Merge pull request #6073 from prplz/msgpack-unpack-requires-readable

dhalbert · web-flow · commit 1603dbb2d335 · 2022-02-21T12:06:07.000-05:00
msgpack.unpack requires a readable stream
diff --git a/shared-module/msgpack/__init__.c b/shared-module/msgpack/__init__.c
@@ -497,6 +497,6 @@ void common_hal_msgpack_pack(mp_obj_t obj, mp_obj_t stream_obj, mp_obj_t default
 }
 
 mp_obj_t common_hal_msgpack_unpack(mp_obj_t stream_obj, mp_obj_t ext_hook, bool use_list) {
-    msgpack_stream_t stream = get_stream(stream_obj, MP_STREAM_OP_WRITE);
+    msgpack_stream_t stream = get_stream(stream_obj, MP_STREAM_OP_READ);
     return unpack(&stream, ext_hook, use_list);
 }

Original file line number	Diff line number	Diff line change
`@@ -497,6 +497,6 @@ void common_hal_msgpack_pack(mp_obj_t obj, mp_obj_t stream_obj, mp_obj_t default`
`497`	`497`	`}`
`498`	`498`
`499`	`499`	`mp_obj_t common_hal_msgpack_unpack(mp_obj_t stream_obj, mp_obj_t ext_hook, bool use_list) {`
`500`		`- msgpack_stream_t stream = get_stream(stream_obj, MP_STREAM_OP_WRITE);`
	`500`	`+ msgpack_stream_t stream = get_stream(stream_obj, MP_STREAM_OP_READ);`
`501`	`501`	`return unpack(&stream, ext_hook, use_list);`
`502`	`502`	`}`