raspberrypi: Drop support for auto-reversing swapped encoder

Author: jepler

ports/raspberrypi/common-hal/rotaryio/IncrementalEncoder.c

@@ -60,17 +60,14 @@ STATIC void incrementalencoder_interrupt_handler(void *self_in);
 void common_hal_rotaryio_incrementalencoder_construct(rotaryio_incrementalencoder_obj_t *self,
     const mcu_pin_obj_t *pin_a, const mcu_pin_obj_t *pin_b) {
     mp_obj_t pins[] = {MP_OBJ_FROM_PTR(pin_a), MP_OBJ_FROM_PTR(pin_b)};
-    bool swap = false;
     if (!common_hal_rp2pio_pins_are_sequential(2, pins)) {
         pins[0] = MP_OBJ_FROM_PTR(pin_b);
         pins[1] = MP_OBJ_FROM_PTR(pin_a);
-        swap = true;
         if (!common_hal_rp2pio_pins_are_sequential(2, pins)) {
             mp_raise_RuntimeError(translate("Pins must be sequential"));
         }
     }
 
-    self->swap = swap;
     self->position = 0;
     self->quarter_count = 0;
 
@@ -113,12 +110,12 @@ void common_hal_rotaryio_incrementalencoder_deinit(rotaryio_incrementalencoder_o
 }
 
 mp_int_t common_hal_rotaryio_incrementalencoder_get_position(rotaryio_incrementalencoder_obj_t *self) {
-    return self->swap ? -self->position : self->position;
+    return self->position;
 }
 
 void common_hal_rotaryio_incrementalencoder_set_position(rotaryio_incrementalencoder_obj_t *self,
     mp_int_t new_position) {
-    self->position = self->swap ? -new_position : new_position;
+    self->position = new_position;
 }
 
 STATIC void incrementalencoder_interrupt_handler(void *self_in) {

ports/raspberrypi/common-hal/rotaryio/IncrementalEncoder.h

@@ -37,5 +37,4 @@ typedef struct {
     uint8_t last_state : 4;   // <old A><old B><new A><new B>
     int8_t quarter_count : 4; // count intermediate transitions between detents
     mp_int_t position;
-    bool swap;
 } rotaryio_incrementalencoder_obj_t;