genlast: Actually catch errors when preprocessing files

Due to a number of problems, an error calling the preprocessor wasn't
making the whole genlast process fail.

Now, after an execption during preprocess is printed, it is re-raised.
Then, by actually collating the results of executor.map, the exception
will be raised in the main thread context. Any CalledProcessError is simply
converted to a nonzero exit status.

Author: jepler

py/genlast.py

@@ -48,6 +48,7 @@ def preprocess(command, output_dir, fn):
         process_file(fn, output_dir, output)
     except Exception as e:
         print(e, file=sys.stderr)
+        raise
 
 
 def maybe_preprocess(command, output_dir, fn):
@@ -72,6 +73,18 @@ def maybe_preprocess(command, output_dir, fn):
     # Mac and Windows use 'spawn'.  Uncomment this during testing to catch spawn-specific problems on Linux.
     # multiprocessing.set_start_method("spawn")
     executor = ProcessPoolExecutor(max_workers=multiprocessing.cpu_count() + 1)
-    executor.map(maybe_preprocess, itertools.repeat(command), itertools.repeat(output_dir), check)
-    executor.map(preprocess, itertools.repeat(command), itertools.repeat(output_dir), always)
+    results = []
+    try:
+        results.extend(
+            executor.map(
+                maybe_preprocess, itertools.repeat(command), itertools.repeat(output_dir), check
+            )
+        )
+        results.extend(
+            executor.map(
+                preprocess, itertools.repeat(command), itertools.repeat(output_dir), always
+            )
+        )
+    except subprocess.CalledProcessError:
+        raise SystemExit(1)
     executor.shutdown()