Skip to content

Commit 4da4783

Browse files
committed
Fix serial console output & add more boards
1 parent 305bed6 commit 4da4783

File tree

7 files changed

+18
-6
lines changed

7 files changed

+18
-6
lines changed

ports/esp32s2/boards/electroniccats_bastwifi/mpconfigboard.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,8 @@
2929
#define MICROPY_HW_BOARD_NAME "BastWiFi"
3030
#define MICROPY_HW_MCU_NAME "ESP32S2"
3131

32+
#define CIRCUITPY_BOOT_BUTTON (&pin_GPIO0)
33+
34+
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up.\n"
35+
3236
#define AUTORESET_DELAY_MS 500

ports/esp32s2/boards/espressif_kaluga_1/mpconfigboard.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,8 @@
3131

3232
#define MICROPY_HW_NEOPIXEL (&pin_GPIO45)
3333

34+
#define CIRCUITPY_BOOT_BUTTON (&pin_GPIO0)
35+
36+
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up.\n"
37+
3438
#define AUTORESET_DELAY_MS 500

ports/esp32s2/boards/espressif_saola_1_wroom/mpconfigboard.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@
3333

3434
#define CIRCUITPY_BOOT_BUTTON (&pin_GPIO0)
3535

36-
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up."
36+
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up.\n"
3737

3838
#define AUTORESET_DELAY_MS 500

ports/esp32s2/boards/espressif_saola_1_wrover/mpconfigboard.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@
3333

3434
#define CIRCUITPY_BOOT_BUTTON (&pin_GPIO0)
3535

36-
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up."
36+
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up.\n"
3737

3838
#define AUTORESET_DELAY_MS 500

ports/esp32s2/boards/microdev_micro_s2/mpconfigboard.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@
3434

3535
#define CIRCUITPY_BOOT_BUTTON (&pin_GPIO0)
3636

37-
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up."
37+
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up.\n"
3838

3939
#define AUTORESET_DELAY_MS 500

ports/esp32s2/boards/unexpectedmaker_feathers2/mpconfigboard.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@
2929
#define MICROPY_HW_BOARD_NAME "FeatherS2"
3030
#define MICROPY_HW_MCU_NAME "ESP32S2"
3131

32+
#define CIRCUITPY_BOOT_BUTTON (&pin_GPIO0)
33+
34+
#define BOARD_USER_SAFE_MODE_ACTION "pressing boot button at start up.\n"
35+
3236
#define AUTORESET_DELAY_MS 500
3337

3438
// Doesn't work with this on.

supervisor/shared/safe_mode.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ safe_mode_t wait_for_safe_mode_reset(void) {
7272
// Blink on for 100, off for 100, on for 100, off for 100 and on for 200
7373
common_hal_digitalio_digitalinout_set_value(&status_led, diff > 100 && diff / 100 != 2 && diff / 100 != 4);
7474
#endif
75-
#ifdef CIRCUITPY_BOOT_BUTTON
75+
#ifdef CIRCUITPY_BOOT_BUTTON
7676
if (!common_hal_digitalio_digitalinout_get_value(&boot_button)) {
7777
return USER_SAFE_MODE;
7878
}
@@ -120,11 +120,11 @@ void print_safe_mode_message(safe_mode_t reason) {
120120
// Output a user safe mode string if it's set.
121121
serial_write_compressed(translate("You requested starting safe mode by "));
122122
serial_write_compressed(translate(BOARD_USER_SAFE_MODE_ACTION));
123-
serial_write_compressed(translate("\nTo exit, please reset the board without "));
123+
serial_write_compressed(translate("To exit, please reset the board without "));
124124
serial_write_compressed(translate(BOARD_USER_SAFE_MODE_ACTION));
125-
serial_write("\n");
126125
#else
127126
// fallthrough
127+
serial_write_compressed(translate("CircuitPython is in safe mode with status being USER_SAFE_MODE but no specific reason was provided.\n"));
128128
#endif
129129
return;
130130
case MANUAL_SAFE_MODE:

0 commit comments

Comments
 (0)