Skip to content

Commit 53b6c4b

Browse files
authored
Merge pull request #5884 from tannewt/s3_heap
Increase S3 without PSRAM heap size and fix S2 builds
2 parents c3dc0b1 + c839d9b commit 53b6c4b

File tree

6 files changed

+21
-13
lines changed

6 files changed

+21
-13
lines changed

ports/espressif/esp-idf-config/sdkconfig-esp32s2.defaults

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,12 @@ CONFIG_ESP_SLEEP_POWER_DOWN_FLASH=y
8383
# end of Sleep Config
8484

8585
#
86-
# ESP System Settings
86+
# PHY
8787
#
88-
CONFIG_ESP_SYSTEM_SINGLE_CORE_MODE=y
89-
# end of ESP System Settings
88+
# CONFIG_ESP_PHY_ENABLE_USB is not set
89+
# end of PHY
9090

91-
CONFIG_ESP_SYSTEM_MEMPROT_DEPCHECK=y
91+
CONFIG_ESP_SYSTEM_SINGLE_CORE_MODE=y
9292
#
9393
# Memory protection
9494
#
@@ -151,10 +151,6 @@ CONFIG_ESP32_PHY_CALIBRATION_AND_DATA_STORAGE=y
151151
# CONFIG_ESP32_PHY_INIT_DATA_IN_PARTITION is not set
152152
CONFIG_ESP32_PHY_MAX_WIFI_TX_POWER=20
153153
CONFIG_ESP32_PHY_MAX_TX_POWER=20
154-
CONFIG_ESP32S2_PANIC_PRINT_HALT=y
155-
# CONFIG_ESP32S2_PANIC_PRINT_REBOOT is not set
156-
# CONFIG_ESP32S2_PANIC_SILENT_REBOOT is not set
157-
# CONFIG_ESP32S2_PANIC_GDBSTUB is not set
158154
CONFIG_ESP32S2_ALLOW_RTC_FAST_MEM_AS_HEAP=y
159155
CONFIG_ESP32H2_MEMPROT_FEATURE=y
160156
CONFIG_ESP32H2_MEMPROT_FEATURE_LOCK=y

ports/espressif/esp-idf-config/sdkconfig-esp32s3.defaults

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,8 @@ CONFIG_ESP32S3_UNIVERSAL_MAC_ADDRESSES=4
8686
# end of MAC Config
8787

8888
CONFIG_ESP_SLEEP_GPIO_RESET_WORKAROUND=y
89+
90+
CONFIG_ESP_PHY_ENABLE_USB=y
8991
# CONFIG_ESP_MAIN_TASK_AFFINITY_CPU0 is not set
9092
CONFIG_ESP_MAIN_TASK_AFFINITY_CPU1=y
9193
# CONFIG_ESP_MAIN_TASK_AFFINITY_NO_AFFINITY is not set
@@ -130,10 +132,6 @@ CONFIG_ESP32_PHY_CALIBRATION_AND_DATA_STORAGE=y
130132
# CONFIG_ESP32_PHY_INIT_DATA_IN_PARTITION is not set
131133
CONFIG_ESP32_PHY_MAX_WIFI_TX_POWER=20
132134
CONFIG_ESP32_PHY_MAX_TX_POWER=20
133-
# CONFIG_ESP32S2_PANIC_PRINT_HALT is not set
134-
# CONFIG_ESP32S2_PANIC_PRINT_REBOOT is not set
135-
CONFIG_ESP32S2_PANIC_SILENT_REBOOT=y
136-
# CONFIG_ESP32S2_PANIC_GDBSTUB is not set
137135
CONFIG_ESP32S2_ALLOW_RTC_FAST_MEM_AS_HEAP=y
138136
# CONFIG_ESP32_ENABLE_COREDUMP_TO_FLASH is not set
139137
# CONFIG_ESP32_ENABLE_COREDUMP_TO_UART is not set

ports/espressif/esp-idf-config/sdkconfig-opt.defaults

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@ CONFIG_COMPILER_OPTIMIZATION_LEVEL_RELEASE=y
7575
CONFIG_OPTIMIZATION_ASSERTIONS_SILENT=y
7676
# CONFIG_OPTIMIZATION_ASSERTIONS_DISABLED is not set
7777
CONFIG_OPTIMIZATION_ASSERTION_LEVEL=1
78+
# CONFIG_ESP32S2_PANIC_PRINT_HALT is not set
79+
# CONFIG_ESP32S2_PANIC_PRINT_REBOOT is not set
80+
CONFIG_ESP32S2_PANIC_SILENT_REBOOT=y
81+
# CONFIG_ESP32S2_PANIC_GDBSTUB is not set
7882
# CONFIG_CONSOLE_UART_DEFAULT is not set
7983
# CONFIG_CONSOLE_UART_CUSTOM is not set
8084
CONFIG_ESP_CONSOLE_UART_NONE=y

ports/espressif/esp-idf-config/sdkconfig.defaults

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,6 @@ CONFIG_ESP_PHY_CALIBRATION_AND_DATA_STORAGE=y
246246
# CONFIG_ESP_PHY_INIT_DATA_IN_PARTITION is not set
247247
CONFIG_ESP_PHY_MAX_WIFI_TX_POWER=20
248248
CONFIG_ESP_PHY_MAX_TX_POWER=20
249-
CONFIG_ESP_PHY_ENABLE_USB=y
250249
# end of PHY
251250

252251
# CONFIG_PM_ENABLE is not set

ports/espressif/supervisor/port.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,17 @@
8181
#include "esp32/spiram.h"
8282
#endif
8383

84+
// Heap sizes for when there is no external RAM for CircuitPython to use
85+
// exclusively.
86+
#ifdef CONFIG_IDF_TARGET_ESP32S2
8487
#define HEAP_SIZE (48 * 1024)
88+
#endif
89+
#ifdef CONFIG_IDF_TARGET_ESP32S3
90+
#define HEAP_SIZE (176 * 1024)
91+
#endif
92+
#ifdef CONFIG_IDF_TARGET_ESP32C3
93+
#define HEAP_SIZE (88 * 1024)
94+
#endif
8595

8696
uint32_t *heap;
8797
uint32_t heap_size;

ports/espressif/tools/update_sdkconfig.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
"CONFIG_SDK_TOOLPREFIX",
4949
"CONFIG_TOOLPREFIX",
5050
"ESP_SLEEP_GPIO_RESET_WORKAROUND",
51+
"CONFIG_ESP_PHY_ENABLE_USB",
5152
]
5253

5354
BOARD_SETTINGS = [

0 commit comments

Comments
 (0)