Skip to content

Commit 6a63d20

Browse files
committed
Fixing remaining stub mypy issues + run check-stubs to CI
1 parent 09ae9ae commit 6a63d20

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
run: MICROPY_CPYTHON3=python3.8 MICROPY_MICROPYTHON=../ports/unix/micropython_coverage ./run-tests -j1 --via-mpy -d basics float
6969
working-directory: tests
7070
- name: Stubs
71-
run: make stubs -j2
71+
run: make check-stubs -j2
7272
- uses: actions/upload-artifact@v2
7373
with:
7474
name: stubs

shared-bindings/ipaddress/IPv4Address.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ const mp_obj_property_t ipaddress_ipv4address_version_obj = {
126126
(mp_obj_t)&mp_const_none_obj},
127127
};
128128

129-
//| def __eq__(self, other: IPv4Address) -> bool:
129+
//| def __eq__(self, other: object) -> bool:
130130
//| """Two Address objects are equal if their addresses and address types are equal."""
131131
//| ...
132132
//|

shared-bindings/socketpool/SocketPool.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ STATIC mp_obj_t socketpool_socketpool_make_new(const mp_obj_type_t *type, size_t
5858
}
5959

6060

61-
//| def socket(self, family: int = AF_INET, type: int = SOCK_STREAM, proto: int = IPPROTO_TCP) -> None:
61+
//| def socket(self, family: int, type: int, proto: int) -> socketpool.Socket:
6262
//| """Create a new socket
6363
//|
6464
//| :param ~int family: AF_INET or AF_INET6

0 commit comments

Comments
 (0)