Skip to content

Commit 7ffb2d3

Browse files
committed
Remove unnecessary defines and update echo mix default.
1 parent fd8567b commit 7ffb2d3

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

shared-bindings/audiodelays/Echo.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
#include "shared-bindings/util.h"
1717
#include "shared-module/synthio/block.h"
1818

19-
#define DECAY_DEFAULT 0.7f
20-
#define MIX_DEFAULT 0.25f
21-
2219
//| class Echo:
2320
//| """An Echo effect"""
2421
//|

shared-bindings/audiofilters/Filter.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
#include "shared-bindings/util.h"
1717
#include "shared-module/synthio/block.h"
1818

19-
#define MIX_DEFAULT 1.0f
20-
2119
//| class Filter:
2220
//| """A Filter effect"""
2321
//|

shared-module/audiodelays/Echo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ void common_hal_audiodelays_echo_construct(audiodelays_echo_obj_t *self, uint32_
6868
synthio_block_assign_slot(delay_ms, &self->delay_ms, MP_QSTR_delay_ms);
6969

7070
if (mix == MP_OBJ_NULL) {
71-
mix = mp_obj_new_float(MICROPY_FLOAT_CONST(0.5));
71+
mix = mp_obj_new_float(MICROPY_FLOAT_CONST(0.25));
7272
}
7373
synthio_block_assign_slot(mix, &self->mix, MP_QSTR_mix);
7474

0 commit comments

Comments
 (0)