Skip to content

Commit 8599f7a

Browse files
iabdalkaderdpgeorge
authored andcommitted
rp2/machine_uart: Add hardware flow control support.
1 parent 9f71a11 commit 8599f7a

File tree

1 file changed

+55
-4
lines changed

1 file changed

+55
-4
lines changed

ports/rp2/machine_uart.c

Lines changed: 55 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,29 @@
4040
#define DEFAULT_UART_STOP (1)
4141
#define DEFAULT_UART0_TX (0)
4242
#define DEFAULT_UART0_RX (1)
43+
#define DEFAULT_UART0_CTS (2)
44+
#define DEFAULT_UART0_RTS (3)
4345
#define DEFAULT_UART1_TX (4)
4446
#define DEFAULT_UART1_RX (5)
47+
#define DEFAULT_UART1_CTS (6)
48+
#define DEFAULT_UART1_RTS (7)
4549
#define DEFAULT_BUFFER_SIZE (256)
4650
#define MIN_BUFFER_SIZE (32)
4751
#define MAX_BUFFER_SIZE (32766)
4852

4953
#define IS_VALID_PERIPH(uart, pin) (((((pin) + 4) & 8) >> 3) == (uart))
5054
#define IS_VALID_TX(uart, pin) (((pin) & 3) == 0 && IS_VALID_PERIPH(uart, pin))
5155
#define IS_VALID_RX(uart, pin) (((pin) & 3) == 1 && IS_VALID_PERIPH(uart, pin))
56+
#define IS_VALID_CTS(uart, pin) (((pin) & 3) == 2 && IS_VALID_PERIPH(uart, pin))
57+
#define IS_VALID_RTS(uart, pin) (((pin) & 3) == 3 && IS_VALID_PERIPH(uart, pin))
5258

5359
#define UART_INVERT_TX (1)
5460
#define UART_INVERT_RX (2)
5561
#define UART_INVERT_MASK (UART_INVERT_TX | UART_INVERT_RX)
5662

63+
#define UART_HWCONTROL_CTS (1)
64+
#define UART_HWCONTROL_RTS (2)
65+
5766
typedef struct _machine_uart_obj_t {
5867
mp_obj_base_t base;
5968
uart_inst_t *const uart;
@@ -64,9 +73,12 @@ typedef struct _machine_uart_obj_t {
6473
uint8_t stop;
6574
uint8_t tx;
6675
uint8_t rx;
76+
uint8_t cts;
77+
uint8_t rts;
6778
uint16_t timeout; // timeout waiting for first char (in ms)
6879
uint16_t timeout_char; // timeout waiting between chars (in ms)
6980
uint8_t invert;
81+
uint8_t flow;
7082
ringbuf_t read_buffer;
7183
bool read_lock;
7284
ringbuf_t write_buffer;
@@ -75,9 +87,9 @@ typedef struct _machine_uart_obj_t {
7587

7688
STATIC machine_uart_obj_t machine_uart_obj[] = {
7789
{{&machine_uart_type}, uart0, 0, 0, DEFAULT_UART_BITS, UART_PARITY_NONE, DEFAULT_UART_STOP,
78-
DEFAULT_UART0_TX, DEFAULT_UART0_RX, 0, 0, 0, {NULL, 1, 0, 0}, 0, {NULL, 1, 0, 0}, 0},
90+
DEFAULT_UART0_TX, DEFAULT_UART0_RX, DEFAULT_UART0_CTS, DEFAULT_UART0_RTS, 0, 0, 0, 0, {NULL, 1, 0, 0}, 0, {NULL, 1, 0, 0}, 0},
7991
{{&machine_uart_type}, uart1, 1, 0, DEFAULT_UART_BITS, UART_PARITY_NONE, DEFAULT_UART_STOP,
80-
DEFAULT_UART1_TX, DEFAULT_UART1_RX, 0, 0, 0, {NULL, 1, 0, 0}, 0, {NULL, 1, 0, 0}, 0,},
92+
DEFAULT_UART1_TX, DEFAULT_UART1_RX, DEFAULT_UART1_CTS, DEFAULT_UART1_RTS, 0, 0, 0, 0, {NULL, 1, 0, 0}, 0, {NULL, 1, 0, 0}, 0},
8193
};
8294

8395
STATIC const char *_parity_name[] = {"None", "0", "1"};
@@ -140,8 +152,8 @@ STATIC void machine_uart_print(const mp_print_t *print, mp_obj_t self_in, mp_pri
140152
}
141153

142154
STATIC mp_obj_t machine_uart_make_new(const mp_obj_type_t *type, size_t n_args, size_t n_kw, const mp_obj_t *all_args) {
143-
enum { ARG_id, ARG_baudrate, ARG_bits, ARG_parity, ARG_stop, ARG_tx, ARG_rx,
144-
ARG_timeout, ARG_timeout_char, ARG_invert, ARG_txbuf, ARG_rxbuf};
155+
enum { ARG_id, ARG_baudrate, ARG_bits, ARG_parity, ARG_stop, ARG_tx, ARG_rx, ARG_cts, ARG_rts,
156+
ARG_timeout, ARG_timeout_char, ARG_invert, ARG_flow, ARG_txbuf, ARG_rxbuf};
145157
static const mp_arg_t allowed_args[] = {
146158
{ MP_QSTR_id, MP_ARG_REQUIRED | MP_ARG_OBJ, {.u_rom_obj = MP_ROM_NONE} },
147159
{ MP_QSTR_baudrate, MP_ARG_INT, {.u_int = -1} },
@@ -150,9 +162,12 @@ STATIC mp_obj_t machine_uart_make_new(const mp_obj_type_t *type, size_t n_args,
150162
{ MP_QSTR_stop, MP_ARG_INT, {.u_int = -1} },
151163
{ MP_QSTR_tx, MP_ARG_KW_ONLY | MP_ARG_OBJ, {.u_rom_obj = MP_ROM_NONE} },
152164
{ MP_QSTR_rx, MP_ARG_KW_ONLY | MP_ARG_OBJ, {.u_rom_obj = MP_ROM_NONE} },
165+
{ MP_QSTR_cts, MP_ARG_KW_ONLY | MP_ARG_OBJ, {.u_rom_obj = MP_ROM_NONE} },
166+
{ MP_QSTR_rts, MP_ARG_KW_ONLY | MP_ARG_OBJ, {.u_rom_obj = MP_ROM_NONE} },
153167
{ MP_QSTR_timeout, MP_ARG_KW_ONLY | MP_ARG_INT, {.u_int = -1} },
154168
{ MP_QSTR_timeout_char, MP_ARG_KW_ONLY | MP_ARG_INT, {.u_int = -1} },
155169
{ MP_QSTR_invert, MP_ARG_KW_ONLY | MP_ARG_INT, {.u_int = -1} },
170+
{ MP_QSTR_flow, MP_ARG_KW_ONLY | MP_ARG_INT, {.u_int = -1} },
156171
{ MP_QSTR_txbuf, MP_ARG_KW_ONLY | MP_ARG_INT, {.u_int = -1} },
157172
{ MP_QSTR_rxbuf, MP_ARG_KW_ONLY | MP_ARG_INT, {.u_int = -1} },
158173
};
@@ -212,6 +227,22 @@ STATIC mp_obj_t machine_uart_make_new(const mp_obj_type_t *type, size_t n_args,
212227
self->rx = rx;
213228
}
214229

230+
// Set CTS/RTS pins if configured.
231+
if (args[ARG_cts].u_obj != mp_const_none) {
232+
int cts = mp_hal_get_pin_obj(args[ARG_cts].u_obj);
233+
if (!IS_VALID_CTS(self->uart_id, cts)) {
234+
mp_raise_ValueError(MP_ERROR_TEXT("bad CTS pin"));
235+
}
236+
self->cts = cts;
237+
}
238+
if (args[ARG_rts].u_obj != mp_const_none) {
239+
int rts = mp_hal_get_pin_obj(args[ARG_rts].u_obj);
240+
if (!IS_VALID_RTS(self->uart_id, rts)) {
241+
mp_raise_ValueError(MP_ERROR_TEXT("bad RTS pin"));
242+
}
243+
self->rts = rts;
244+
}
245+
215246
// Set timeout if configured.
216247
if (args[ARG_timeout].u_int >= 0) {
217248
self->timeout = args[ARG_timeout].u_int;
@@ -230,6 +261,14 @@ STATIC mp_obj_t machine_uart_make_new(const mp_obj_type_t *type, size_t n_args,
230261
self->invert = args[ARG_invert].u_int;
231262
}
232263

264+
// Set hardware flow control if configured.
265+
if (args[ARG_flow].u_int >= 0) {
266+
if (args[ARG_flow].u_int & ~(UART_HWCONTROL_CTS | UART_HWCONTROL_RTS)) {
267+
mp_raise_ValueError(MP_ERROR_TEXT("bad hardware flow control mask"));
268+
}
269+
self->flow = args[ARG_flow].u_int;
270+
}
271+
233272
self->read_lock = false;
234273

235274
// Set the RX buffer size if configured.
@@ -278,6 +317,15 @@ STATIC mp_obj_t machine_uart_make_new(const mp_obj_type_t *type, size_t n_args,
278317
gpio_set_outover(self->tx, GPIO_OVERRIDE_INVERT);
279318
}
280319

320+
// Set hardware flow control if configured.
321+
if (self->flow & UART_HWCONTROL_CTS) {
322+
gpio_set_function(self->cts, GPIO_FUNC_UART);
323+
}
324+
if (self->flow & UART_HWCONTROL_RTS) {
325+
gpio_set_function(self->rts, GPIO_FUNC_UART);
326+
}
327+
uart_set_hw_flow(self->uart, self->flow & UART_HWCONTROL_CTS, self->flow & UART_HWCONTROL_RTS);
328+
281329
// Allocate the RX/TX buffers.
282330
ringbuf_alloc(&(self->read_buffer), rxbuf_len + 1);
283331
MP_STATE_PORT(rp2_uart_rx_buffer[uart_id]) = self->read_buffer.buf;
@@ -333,6 +381,9 @@ STATIC const mp_rom_map_elem_t machine_uart_locals_dict_table[] = {
333381
{ MP_ROM_QSTR(MP_QSTR_INV_TX), MP_ROM_INT(UART_INVERT_TX) },
334382
{ MP_ROM_QSTR(MP_QSTR_INV_RX), MP_ROM_INT(UART_INVERT_RX) },
335383

384+
{ MP_ROM_QSTR(MP_QSTR_CTS), MP_ROM_INT(UART_HWCONTROL_CTS) },
385+
{ MP_ROM_QSTR(MP_QSTR_RTS), MP_ROM_INT(UART_HWCONTROL_RTS) },
386+
336387
};
337388
STATIC MP_DEFINE_CONST_DICT(machine_uart_locals_dict, machine_uart_locals_dict_table);
338389

0 commit comments

Comments
 (0)