Skip to content

Commit 95179be

Browse files
authored
Merge pull request #10041 from jepler/fix-ci-matrix-copy
ci_set_matrix: the `boards` set needs to be a copy
2 parents a92e64c + f43efc9 commit 95179be

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tools/ci_set_matrix.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,10 @@ def get_settings(board):
187187
# As a (nearly) last resort, for some certain files, we compute the settings from the
188188
# makefile for each board and determine whether to build them that way
189189
if file.startswith("frozen") or file.startswith("supervisor") or module_matches:
190-
boards = port_to_board[port] if port else all_board_ids
190+
# Take a copy, because we remove items from it below. For
191+
# instance, if we remove items from, say, all_board_ids, then
192+
# the logic to build all boards breaks.
193+
boards = set(port_to_board[port] if port else all_board_ids)
191194

192195
# Zephyr boards don't use make, so build them and don't compute their settings.
193196
for board in port_to_board["zephyr-cp"]:

0 commit comments

Comments
 (0)