Skip to content

Commit a0553ea

Browse files
authored
Merge pull request #5708 from dhalbert/samd-pinalarm-intclr
Clear SAMD TAMPER interrupt in pinalarm properly
2 parents f695b14 + bbe3051 commit a0553ea

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

ports/atmel-samd/common-hal/alarm/pin/PinAlarm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ void alarm_pin_pinalarm_reset(void) {
164164
woke_up = false;
165165
SAMD_ALARM_FLAG &= ~SAMD_ALARM_FLAG_PIN; // clear flag
166166
// Disable TAMPER interrupt
167-
RTC->MODE0.INTENCLR.bit.TAMPER = 1;
167+
RTC->MODE0.INTENCLR.reg = RTC_MODE0_INTENCLR_TAMPER;
168168
// Disable TAMPER control
169169
common_hal_mcu_disable_interrupts();
170170
RTC->MODE0.CTRLA.bit.ENABLE = 0; // Disable the RTC

ports/atmel-samd/common-hal/frequencyio/FrequencyIn.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,13 @@ static void frequencyin_reference_tc_init(void) {
185185

186186
#ifdef SAMD21
187187
tc->COUNT16.CTRLA.reg = TC_CTRLA_MODE_COUNT16 | TC_CTRLA_PRESCALER_DIV1;
188-
tc->COUNT16.INTENSET.bit.OVF = 1;
188+
tc->COUNT16.INTENSET.reg = TC_INTENSET_OVF;
189189
NVIC_EnableIRQ(TC3_IRQn + reference_tc);
190190
#endif
191191
#ifdef SAM_D5X_E5X
192192
tc->COUNT16.CTRLA.reg = TC_CTRLA_MODE_COUNT16 |
193193
TC_CTRLA_PRESCALER_DIV1;
194-
tc->COUNT16.INTENSET.bit.OVF = 1;
194+
tc->COUNT16.INTENSET.reg = TC_INTENSET_OVF;
195195
NVIC_EnableIRQ(TC0_IRQn + reference_tc);
196196
#endif
197197
}

ports/atmel-samd/common-hal/watchdog/WatchDogTimer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ STATIC void setup_wdt(watchdog_watchdogtimer_obj_t *self, int setting) {
5858
while (WDT->SYNCBUSY.reg) { // Sync CTRL write
5959
}
6060

61-
WDT->INTENCLR.bit.EW = 1; // Disable early warning interrupt
61+
WDT->INTENCLR.reg = WDT_INTENCLR_EW; // Disable early warning interrupt
6262
WDT->CONFIG.bit.PER = setting; // Set period for chip reset
6363
WDT->CTRLA.bit.WEN = 0; // Disable window mode
6464
while (WDT->SYNCBUSY.reg) { // Sync CTRL write

shared-bindings/keypad/__init__.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
//| """
4343
//|
4444

45-
STATIC mp_map_elem_t keypad_module_globals_table[] = {
45+
STATIC mp_rom_map_elem_t keypad_module_globals_table[] = {
4646
{ MP_ROM_QSTR(MP_QSTR___name__), MP_OBJ_NEW_QSTR(MP_QSTR_keypad) },
4747
{ MP_ROM_QSTR(MP_QSTR_Event), MP_OBJ_FROM_PTR(&keypad_event_type) },
4848
{ MP_ROM_QSTR(MP_QSTR_EventQueue), MP_OBJ_FROM_PTR(&keypad_eventqueue_type) },
@@ -51,7 +51,7 @@ STATIC mp_map_elem_t keypad_module_globals_table[] = {
5151
{ MP_ROM_QSTR(MP_QSTR_ShiftRegisterKeys), MP_OBJ_FROM_PTR(&keypad_shiftregisterkeys_type) },
5252
};
5353

54-
STATIC MP_DEFINE_MUTABLE_DICT(keypad_module_globals, keypad_module_globals_table);
54+
STATIC MP_DEFINE_CONST_DICT(keypad_module_globals, keypad_module_globals_table);
5555

5656
const mp_obj_module_t keypad_module = {
5757
.base = { &mp_type_module },

0 commit comments

Comments
 (0)