Skip to content

Commit a133074

Browse files
committed
text fixes, postpone warning disable
1 parent bc581fb commit a133074

File tree

2 files changed

+3
-29
lines changed

2 files changed

+3
-29
lines changed

ports/mimxrt10xx/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,9 @@ endif
9393

9494
CFLAGS += $(INC) -Wall -Wno-cast-align -std=gnu11 -nostdlib $(BASE_CFLAGS) $(CFLAGS_MOD) $(COPT)
9595

96+
# TODO: add these when -Werror is applied
9697
# Disable some warnings, as do most ports. NXP SDK causes undef, tinyusb causes cast-align
97-
CFLAGS += -Wno-undef -Wno-cast-align
98+
# CFLAGS += -Wno-undef -Wno-cast-align
9899

99100
CFLAGS += \
100101
-mthumb \

ports/mimxrt10xx/common-hal/busio/SPI.c

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
STATIC bool reserved_spi[MAX_SPI];
4040
STATIC bool never_reset_spi[MAX_SPI];
4141

42-
static void config_periph_pin(const mcu_periph_obj_t *periph) {
42+
STATIC void config_periph_pin(const mcu_periph_obj_t *periph) {
4343
IOMUXC_SetPinMux(
4444
periph->pin->mux_reg, periph->mux_mode,
4545
periph->input_reg, periph->input_idx,
@@ -153,33 +153,6 @@ void common_hal_busio_spi_construct(busio_spi_obj_t *self,
153153
}
154154
}
155155

156-
// for (uint32_t i = 0; i < sck_count; ++i) {
157-
// if (mcu_spi_sck_list[i].pin != clock)
158-
// continue;
159-
160-
// for (uint32_t j = 0; j < miso_count; ++j) {
161-
// if (mcu_spi_miso_list[j].pin != miso)
162-
// continue;
163-
164-
// if (mcu_spi_miso_list[j].bank_idx != mcu_spi_sck_list[i].bank_idx)
165-
// continue;
166-
167-
// for (uint32_t k = 0; k < mosi_count; ++k) {
168-
// if (mcu_spi_mosi_list[k].pin != mosi)
169-
// continue;
170-
171-
// if (mcu_spi_mosi_list[k].bank_idx != mcu_spi_miso_list[j].bank_idx)
172-
// continue;
173-
174-
// self->clock = &mcu_spi_sck_list[i];
175-
// self->miso_pin = &mcu_spi_miso_list[j];
176-
// self->mosi_pin = &mcu_spi_mosi_list[k];
177-
178-
// break;
179-
// }
180-
// }
181-
// }
182-
183156
if (self->clock != NULL && (self->mosi != NULL || self->miso != NULL)) {
184157
self->spi = mcu_spi_banks[self->clock->bank_idx - 1];
185158
} else {

0 commit comments

Comments
 (0)